From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/2] git-http-backend: close pipe for generic PSGI on errors
Date: Fri, 27 May 2016 08:27:09 +0000 [thread overview]
Message-ID: <20160527082709.17629-3-e@80x24.org> (raw)
In-Reply-To: <20160527082709.17629-1-e@80x24.org>
The generic PSGI code needs to avoid resource leaks if
smart cloning is disabled (due to resource contraints).
---
lib/PublicInbox/GitHTTPBackend.pm | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm
index 1819444..58e75cd 100644
--- a/lib/PublicInbox/GitHTTPBackend.pm
+++ b/lib/PublicInbox/GitHTTPBackend.pm
@@ -210,7 +210,12 @@ sub serve_smart {
my $r = $rd_hdr->() or return;
$rd_hdr = undef;
if (scalar(@$r) == 3) { # error:
- $async->close if $async;
+ if ($async) {
+ $async->close; # calls rpipe->close
+ } else {
+ $rpipe->close;
+ $end->();
+ }
return $res->($r);
}
if ($async) {
prev parent reply other threads:[~2016-05-27 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 8:27 [PATCH 0/2] git-http-backend: more cleanups + one fix Eric Wong
2016-05-27 8:27 ` [PATCH 1/2] git-http-backend: move real close to GetlineBody Eric Wong
2016-05-27 8:27 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160527082709.17629-3-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).