From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] config: use popen_rd when spawning `git config'
Date: Mon, 23 May 2016 01:20:16 +0000 [thread overview]
Message-ID: <20160523012016.4995-1-e@80x24.org> (raw)
We may spawn this in a large server process, so be sure
to take advantage of the optional vfork() support when
for folks who set PERL_INLINE_DIRECTORY.
---
lib/PublicInbox/Config.pm | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm
index b38f444..935b044 100644
--- a/lib/PublicInbox/Config.pm
+++ b/lib/PublicInbox/Config.pm
@@ -8,6 +8,7 @@ use warnings;
use base qw/Exporter/;
our @EXPORT_OK = qw/try_cat/;
require PublicInbox::Inbox;
+use PublicInbox::Spawn qw(popen_rd);
use File::Path::Expand qw/expand_filename/;
# returns key-value pairs of config directives in a hash
@@ -77,8 +78,7 @@ sub git_config_dump {
my ($in, $out);
my @cmd = (qw/git config/, "--file=$file", '-l');
my $cmd = join(' ', @cmd);
- my $pid = open(my $fh, '-|', @cmd);
- defined $pid or die "$cmd failed: $!";
+ my $fh = popen_rd(\@cmd);
my %rv;
local $/ = "\n";
foreach my $line (<$fh>) {
@@ -96,8 +96,7 @@ sub git_config_dump {
$rv{$k} = $v;
}
}
- close $fh or die "failed to close ($cmd) pipe: $!";
- $? and warn "$$ $cmd exited with: ($pid) $?";
+ close $fh or die "failed to close ($cmd) pipe: $?";
\%rv;
}
reply other threads:[~2016-05-23 1:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160523012016.4995-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).