From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-5.4 required=3.0 tests=ALL_TRUSTED,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RP_MATCHES_RCVD,URIBL_BLOCKED shortcircuit=no autolearn=unavailable autolearn_force=no version=3.4.0 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 0C32D1F99C for ; Sun, 22 May 2016 06:17:30 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 1/2] http: fix typo: write_buf => write_buf_size Date: Sun, 22 May 2016 06:17:29 +0000 Message-Id: <20160522061730.7884-1-e@80x24.org> In-Reply-To: <20160521234527.21133-1-e@80x24.org> References: <20160521234527.21133-1-e@80x24.org> List-Id: Otherwise, we get deep recursion as we keep calling recursively on giant responses --- lib/PublicInbox/HTTP.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm index d523bd4..6576bf6 100644 --- a/lib/PublicInbox/HTTP.pm +++ b/lib/PublicInbox/HTTP.pm @@ -228,7 +228,7 @@ sub response_write { my $buf = $body->getline; if (defined $buf) { $write->($buf); - if ($self->{write_buf}) { + if ($self->{write_buf_size}) { $body->watch_read(0); $self->write($restart_read); } @@ -243,7 +243,7 @@ sub response_write { local $/ = \8192; while (defined(my $buf = $body->getline)) { $write->($buf); - if ($self->{write_buf}) { + if ($self->{write_buf_size}) { $self->write($pull); return; }