From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.9 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RP_MATCHES_RCVD,URIBL_BLOCKED shortcircuit=no autolearn=unavailable autolearn_force=no version=3.4.0 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id F2C4A1F427 for ; Wed, 18 May 2016 02:34:01 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] feed: inline feed entry generation Date: Wed, 18 May 2016 02:34:01 +0000 Message-Id: <20160518023401.15988-1-e@80x24.org> List-Id: Remove unnecessary wrapper subroutines and constants which are only used once. --- lib/PublicInbox/Feed.pm | 6 +++--- lib/PublicInbox/Hval.pm | 1 - lib/PublicInbox/View.pm | 7 ------- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm index 52fe0db..0b864c2 100644 --- a/lib/PublicInbox/Feed.pm +++ b/lib/PublicInbox/Feed.pm @@ -316,10 +316,10 @@ sub add_to_feed { defined $mid or return 0; $mid = PublicInbox::Hval->new_msgid($mid); my $href = $mid->as_href; - my $content = PublicInbox::View->feed_entry($mime); - defined($content) or return 0; - $mime = undef; + my $content = qq() . + PublicInbox::View::multipart_text_as_html($mime) . + ''; my $date = $header_obj->header('Date'); my $updated = feed_updated($date); diff --git a/lib/PublicInbox/Hval.pm b/lib/PublicInbox/Hval.pm index 70bae7c..9ba7809 100644 --- a/lib/PublicInbox/Hval.pm +++ b/lib/PublicInbox/Hval.pm @@ -16,7 +16,6 @@ our @EXPORT_OK = qw/ascii_html/; # and screw up rendering on some browsers. This is the only CSS style # feature we use. use constant STYLE => ''; -use constant PRE => ""; # legacy my $enc_ascii = find_encoding('us-ascii'); diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index 3fa7cfc..2513cd0 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -73,13 +73,6 @@ sub msg_reply { '
' . $footer .  '
'; } -sub feed_entry { - my ($class, $mime) = @_; - - # no here for