From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00,
	URIBL_BLOCKED shortcircuit=no autolearn=unavailable autolearn_force=no
	version=3.4.0
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 0F70D1FA7C
	for <meta@public-inbox.org>; Tue, 17 May 2016 05:38:50 +0000 (UTC)
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] view: escape Message-ID for "next" link
Date: Tue, 17 May 2016 05:39:06 +0000
Message-Id: <20160517053906.15481-1-e@80x24.org>
List-Id: <meta@public-inbox.org>

Oops, we need to escape Message-IDs since they can contain
bad characters such as '%' in them.  '@' actually seems fine
and does not need to be escaped; however, but we've been
doing it forever.
---
 lib/PublicInbox/View.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index e5329bb..776b859 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -498,7 +498,8 @@ sub html_footer {
 			$irt = ' ' x length('parent ');
 		}
 		if ($next) {
-			$irt .= "<a\nhref=\"$upfx$next/\"\nrel=next>next</a> ";
+			my $n = PublicInbox::Hval->new_msgid($next)->as_href;
+			$irt .= "<a\nhref=\"$upfx$n/\"\nrel=next>next</a> ";
 		} else {
 			$irt .= ' ' x length('next ');
 		}
-- 
EW