From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] spawnpp: use native perl %ENV outside of mod_perl
Date: Tue, 3 May 2016 09:12:30 +0000 [thread overview]
Message-ID: <20160503091230.12477-1-e@80x24.org> (raw)
We only need to use env(1) under mod_perl; since mod_perl
is uncommon nowadays, support native %ENV for a teeny
speedup for folks uncomfortable with running vfork via
Inline::C snippet.
---
lib/PublicInbox/SpawnPP.pm | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/SpawnPP.pm b/lib/PublicInbox/SpawnPP.pm
index dc2ef36..fe95d12 100644
--- a/lib/PublicInbox/SpawnPP.pm
+++ b/lib/PublicInbox/SpawnPP.pm
@@ -19,8 +19,15 @@ sub public_inbox_fork_exec ($$$$$$) {
if ($err != 2) {
dup2($err, 2) or die "dup2 failed for stderr: $!";
}
- exec qw(env -i), @$env, @$cmd;
- die "exec env -i ... $cmd->[0] failed: $!\n";
+
+ if ($ENV{MOD_PERL}) {
+ exec qw(env -i), @$env, @$cmd;
+ die "exec env -i ... $cmd->[0] failed: $!\n";
+ } else {
+ local %ENV = map { split(/=/, $_, 2) } @$env;
+ exec @$cmd;
+ die "exec $cmd->[0] failed: $!\n";
+ }
}
$pid;
}
reply other threads:[~2016-05-03 9:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503091230.12477-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).