From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.4 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, RP_MATCHES_RCVD shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: meta@public-inbox.org Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 2B74220441 for ; Sat, 16 Apr 2016 18:51:16 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] view: show flat thread view in chronological order Date: Sat, 16 Apr 2016 18:51:16 +0000 Message-Id: <20160416185116.10493-1-e@80x24.org> List-Id: Allowing readers new to a topic to follow in chronological order probably makes the most sense. Reverse chronological order may reduce scrolling (e.g. log view); but nearly all non-threaded conversation displays seem to be chronological so perhaps there's a good reason for that. --- lib/PublicInbox/View.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index f07979e..36df7ea 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -174,10 +174,10 @@ sub thread_html { sub emit_thread_html { my ($res, $ctx, $foot, $srch) = @_; my $mid = $ctx->{mid}; - my $msgs = load_results($srch->get_thread($mid)); + my $flat = $ctx->{flat}; + my $msgs = load_results($srch->get_thread($mid, { asc => $flat })); my $nr = scalar @$msgs; return missing_thread($res, $ctx) if $nr == 0; - my $flat = $ctx->{flat}; my $seen = {}; my $state = { res => $res, -- EW