user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] view: eliminate dead code and hash fields
Date: Wed,  6 Apr 2016 07:25:50 +0000	[thread overview]
Message-ID: <20160406072550.11511-1-e@80x24.org> (raw)

These were the vestigial remains of our previous use of
of Message-ID compression.
---
 lib/PublicInbox/View.pm | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index f074a24..2cf7e4f 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -464,8 +464,6 @@ sub thread_inline {
 		seen => { $subj => 1 },
 		srch => $srch,
 		cur => $mid,
-		parent_cmp => defined $parent ? $parent : '',
-		parent => $parent,
 		prev_attr => '',
 		prev_level => 0,
 	};
@@ -474,7 +472,7 @@ sub thread_inline {
 	}
 	$$dst .= "<a\nid=b></a>"; # anchor for body start
 	$ctx->{next_msg} = $state->{next_msg};
-	$ctx->{parent_msg} = $state->{parent};
+	$ctx->{parent_msg} = $parent;
 }
 
 sub _parent_headers_nosrch {
@@ -811,9 +809,6 @@ sub inline_dump {
 	if (my $mime = $node->message) {
 		my $hdr = $mime->header_obj;
 		my $mid = mid_clean($hdr->header_raw('Message-ID'));
-		if ($mid eq $state->{parent_cmp}) {
-			$state->{parent} = $mid;
-		}
 		_inline_header($dst, $state, $upfx, $hdr, $level);
 	} else {
 		my $dot = $level == 0 ? '' : '` ';
-- 
EW


                 reply	other threads:[~2016-04-06  7:25 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160406072550.11511-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).