user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] httpd: remove unnecessary eval
Date: Sat,  5 Mar 2016 21:02:48 +0000	[thread overview]
Message-ID: <20160305210248.24890-1-e@80x24.org> (raw)

We have per-middleware evals to deal with them being missing;
no need to put an eval around the whole thing and use an
extra level of indentation.
---
 script/public-inbox-httpd | 32 +++++++++++++++-----------------
 1 file changed, 15 insertions(+), 17 deletions(-)

diff --git a/script/public-inbox-httpd b/script/public-inbox-httpd
index b6c4e67..e7ed3c9 100755
--- a/script/public-inbox-httpd
+++ b/script/public-inbox-httpd
@@ -23,28 +23,26 @@ my $refresh = sub {
 		require PublicInbox::WWW;
 		PublicInbox::WWW->preload;
 		my $www = PublicInbox::WWW->new;
-		$app = eval {
-			builder {
-				enable 'Chunked';
-				eval {
-					enable 'Deflater',
-						content_type => [ qw(
-							text/html
-							text/plain
-							application/atom+xml
-							)]
-				};
-				$@ and warn
+		$app = builder {
+			enable 'Chunked';
+			eval {
+				enable 'Deflater',
+					content_type => [ qw(
+						text/html
+						text/plain
+						application/atom+xml
+						)]
+			};
+			$@ and warn
 "Plack::Middleware::Deflater missing, bandwidth will be wasted\n";
 
-				eval { enable 'ReverseProxy' };
-				$@ and warn
+			eval { enable 'ReverseProxy' };
+			$@ and warn
 "Plack::Middleware::ReverseProxy missing,\n",
 "URL generation for redirects may be wrong if behind a reverse proxy\n";
 
-				enable 'Head';
-				sub { $www->call(@_) };
-			};
+			enable 'Head';
+			sub { $www->call(@_) };
 		};
 	}
 };
-- 
EW


                 reply	other threads:[~2016-03-05 21:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160305210248.24890-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).