From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: meta@public-inbox.org Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id D546063381D for ; Fri, 4 Mar 2016 01:07:17 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] daemon: simplify socket inheriting, slightly Date: Fri, 4 Mar 2016 01:07:17 +0000 Message-Id: <20160304010717.15462-1-e@80x24.org> List-Id: IO::Handle->new_from_fd has existed since at least 1996, so it should be safe to depend on at this point. --- lib/PublicInbox/Daemon.pm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/PublicInbox/Daemon.pm b/lib/PublicInbox/Daemon.pm index 9f33c05..f0be034 100644 --- a/lib/PublicInbox/Daemon.pm +++ b/lib/PublicInbox/Daemon.pm @@ -206,8 +206,7 @@ sub inherit () { my $end = $fds + 2; # LISTEN_FDS_START - 1 my @rv = (); foreach my $fd (3..$end) { - my $s = IO::Handle->new; - $s->fdopen($fd, 'r'); + my $s = IO::Handle->new_from_fd($fd, 'r'); if (my $k = sockname($s)) { $listener_names{$k} = $s; push @rv, $s; -- EW