user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [ssoma PATCH] t/*.t: ensure tests do not touch working directory
@ 2016-03-03  9:05 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2016-03-03  9:05 UTC (permalink / raw)
  To: meta; +Cc: Eric Wong

The working directory may be read-only, instead,
respect TMPDIR which should always be writable.
---
 t/all.t             | 2 +-
 t/extractor.t       | 4 ++--
 t/git.t             | 2 +-
 t/mda-badheaders.t  | 2 +-
 t/mda-conflict.t    | 2 +-
 t/mda-missing-mid.t | 2 +-
 t/remover.t         | 2 +-
 7 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/t/all.t b/t/all.t
index 4eef8b1..0891dc6 100644
--- a/t/all.t
+++ b/t/all.t
@@ -10,7 +10,7 @@ use Email::MIME;
 my $mda = "blib/script/ssoma-mda";
 my $cli = "blib/script/ssoma";
 my $rm = "blib/script/ssoma-rm";
-my $tmp = tempdir('ssoma-all-XXXXXX', CLEANUP => 1);
+my $tmp = tempdir('ssoma-all-XXXXXX', TMPDIR => 1, CLEANUP => 1);
 my $have_ipc_run = eval {
 	require IPC::Run;
 	import IPC::Run qw/run/;
diff --git a/t/extractor.t b/t/extractor.t
index de8fe30..6a4b28f 100644
--- a/t/extractor.t
+++ b/t/extractor.t
@@ -9,8 +9,8 @@ use Ssoma::Git;
 use Ssoma::MDA;
 use File::Temp qw/tempdir/;
 
-my $mdadir = tempdir('ssoma-extractor-mda-XXXXXX', CLEANUP => 1);
-my $outdir = tempdir('ssoma-extractor-out-XXXXXX', CLEANUP => 1);
+my $mdadir = tempdir('ssoma-extractor-mda-XXXXXX', TMPDIR => 1, CLEANUP => 1);
+my $outdir = tempdir('ssoma-extractor-out-XXXXXX', TMPDIR => 1, CLEANUP => 1);
 
 my $outgit = Ssoma::Git->new("$outdir/git");
 my $ex = Ssoma::Extractor->new($outgit);
diff --git a/t/git.t b/t/git.t
index 43ebaf2..40906ae 100644
--- a/t/git.t
+++ b/t/git.t
@@ -7,7 +7,7 @@ use Test::More;
 use Ssoma::Git;
 use Ssoma::GitIndexInfo;
 use File::Temp qw/tempdir/;
-my $tmpdir = tempdir('ssoma-git-XXXXXX', CLEANUP => 1);
+my $tmpdir = tempdir('ssoma-git-XXXXXX', TMPDIR => 1, CLEANUP => 1);
 my $git = Ssoma::Git->new("$tmpdir/gittest");
 
 $git->init_db('-q');
diff --git a/t/mda-badheaders.t b/t/mda-badheaders.t
index 01033aa..edab13c 100644
--- a/t/mda-badheaders.t
+++ b/t/mda-badheaders.t
@@ -10,7 +10,7 @@ use Email::MIME;
 use Digest::SHA qw/sha1_hex/;
 use File::Temp qw/tempdir/;
 
-my $tmpdir = tempdir('ssoma-mda-badheaders-XXXXXX', CLEANUP => 1);
+my $tmpdir = tempdir('ssoma-mda-badheaders-XXXXXX', TMPDIR => 1, CLEANUP => 1);
 my $git = Ssoma::Git->new("$tmpdir/gittest");
 $git->init_db('-q');
 my $mda = Ssoma::MDA->new($git);
diff --git a/t/mda-conflict.t b/t/mda-conflict.t
index 47bf403..21bfb3c 100644
--- a/t/mda-conflict.t
+++ b/t/mda-conflict.t
@@ -10,7 +10,7 @@ use Email::MIME;
 use Digest::SHA qw/sha1_hex/;
 use File::Temp qw/tempdir/;
 
-my $tmpdir = tempdir('ssoma-mda-conflict-XXXXXX', CLEANUP => 1);
+my $tmpdir = tempdir('ssoma-mda-conflict-XXXXXX', TMPDIR => 1, CLEANUP => 1);
 my $git = Ssoma::Git->new("$tmpdir/gittest");
 $git->init_db('-q');
 my $mda = Ssoma::MDA->new($git);
diff --git a/t/mda-missing-mid.t b/t/mda-missing-mid.t
index 5d25d79..aac1826 100644
--- a/t/mda-missing-mid.t
+++ b/t/mda-missing-mid.t
@@ -8,7 +8,7 @@ use Ssoma::MDA;
 use Ssoma::Git;
 use Email::MIME;
 use File::Temp qw/tempdir/;
-my $tmpdir = tempdir('ssoma-mda-missing-mid-XXXXXX', CLEANUP => 1);
+my $tmpdir = tempdir('ssoma-mda-missing-mid-XXXXXX', TMPDIR => 1, CLEANUP => 1);
 my $git = Ssoma::Git->new("$tmpdir/gittest");
 $git->init_db('-q');
 my $mda = Ssoma::MDA->new($git);
diff --git a/t/remover.t b/t/remover.t
index d47081a..aa420b1 100644
--- a/t/remover.t
+++ b/t/remover.t
@@ -11,7 +11,7 @@ use Email::MIME;
 use Digest::SHA qw/sha1_hex/;
 use File::Temp qw/tempdir/;
 
-my $tmpdir = tempdir('ssoma-remover-XXXXXX', CLEANUP => 1);
+my $tmpdir = tempdir('ssoma-remover-XXXXXX', TMPDIR => 1, CLEANUP => 1);
 my $git_dir = "$tmpdir/gittest";
 my $git = Ssoma::Git->new($git_dir);
 $git->init_db('-q');
-- 
EW


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-03-03  9:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-03  9:05 [ssoma PATCH] t/*.t: ensure tests do not touch working directory Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).