user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] fixup Plack-related requires
Date: Mon, 29 Feb 2016 12:51:40 +0000	[thread overview]
Message-ID: <20160229125140.8553-1-e@80x24.org> (raw)

We do not need to load Plack::Request outside of WWW anymore.
---
 examples/public-inbox.psgi | 1 -
 lib/PublicInbox/WWW.pm     | 1 +
 script/public-inbox.cgi    | 2 --
 t/httpd-corner.psgi        | 1 -
 4 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/examples/public-inbox.psgi b/examples/public-inbox.psgi
index dcca3b0..55c113e 100644
--- a/examples/public-inbox.psgi
+++ b/examples/public-inbox.psgi
@@ -9,7 +9,6 @@ use strict;
 use warnings;
 use PublicInbox::WWW;
 PublicInbox::WWW->preload;
-use Plack::Request;
 use Plack::Builder;
 my $www = PublicInbox::WWW->new;
 builder {
diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm
index 98e33fd..2acb4c8 100644
--- a/lib/PublicInbox/WWW.pm
+++ b/lib/PublicInbox/WWW.pm
@@ -13,6 +13,7 @@ package PublicInbox::WWW;
 use 5.008;
 use strict;
 use warnings;
+use Plack::Request;
 use PublicInbox::Config qw(try_cat);
 use URI::Escape qw(uri_escape_utf8 uri_unescape);
 use constant SSOMA_URL => '//ssoma.public-inbox.org/';
diff --git a/script/public-inbox.cgi b/script/public-inbox.cgi
index ee9510c..5b2aefe 100755
--- a/script/public-inbox.cgi
+++ b/script/public-inbox.cgi
@@ -5,9 +5,7 @@
 # Enables using PublicInbox::WWW as a CGI script
 use strict;
 use warnings;
-use Plack::Loader;
 use Plack::Builder;
-use Plack::Request;
 use Plack::Handler::CGI;
 use PublicInbox::WWW;
 BEGIN { PublicInbox::WWW->preload if $ENV{MOD_PERL} }
diff --git a/t/httpd-corner.psgi b/t/httpd-corner.psgi
index 0e0e21a..c3bf523 100644
--- a/t/httpd-corner.psgi
+++ b/t/httpd-corner.psgi
@@ -4,7 +4,6 @@
 # Usage: plackup [OPTIONS] /path/to/this/file
 use strict;
 use warnings;
-use Plack::Request;
 use Plack::Builder;
 require Digest::SHA;
 my $app = sub {
-- 
EW


                 reply	other threads:[~2016-02-29 12:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160229125140.8553-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).