* [PATCH] extmsg: do not modify shared array via prurl
@ 2016-02-26 2:37 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2016-02-26 2:37 UTC (permalink / raw)
To: meta
We cannot modify elements in any shared data strucutures
shared between requests. Oops!
---
lib/PublicInbox/ExtMsg.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/ExtMsg.pm b/lib/PublicInbox/ExtMsg.pm
index 09ee8d6..912a675 100644
--- a/lib/PublicInbox/ExtMsg.pm
+++ b/lib/PublicInbox/ExtMsg.pm
@@ -138,8 +138,8 @@ again:
$code = 300;
$s .= "\nPerhaps try an external site:\n\n";
my $env = $cgi->{env};
- foreach my $u (@EXT_URL) {
- $u = PublicInbox::Hval::prurl($env, $u);
+ foreach my $url (@EXT_URL) {
+ my $u = PublicInbox::Hval::prurl($env, $url);
my $r = sprintf($u, $href);
my $t = sprintf($u, $html);
$s .= qq{<a\nhref="$r">$t</a>\n};
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-02-26 2:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-26 2:37 [PATCH] extmsg: do not modify shared array via prurl Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).