user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] view: reference ghost parent in permalink view
Date: Mon, 1 Feb 2016 02:04:53 +0000	[thread overview]
Message-ID: <20160201020453.GA11445@dcvr.yhbt.net> (raw)

We should not hide the parent Message-ID in this view;
give the user the option to find the message in other archives.
---
 lib/PublicInbox/View.pm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 88ab2d2..70b92a7 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -469,7 +469,12 @@ sub thread_inline {
 	$$dst .= 'Thread: ';
 	my $parent = in_reply_to($cur);
 	if ($nr <= 1) {
-		$$dst .= "[no followups, yet] ($expand)\n";
+		if (defined $parent) {
+			$$dst .= "($expand)\n ";
+			$$dst .= ghost_parent($upfx, $parent) . "\n";
+		} else {
+			$$dst .= "[no followups, yet] ($expand)\n";
+		}
 		$ctx->{next_msg} = undef;
 		$ctx->{parent_msg} = $parent;
 		return;
-- 
EW

                 reply	other threads:[~2016-02-01  2:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160201020453.GA11445@dcvr.yhbt.net \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).