user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] extmsg: fixup comparison for unknown message types
Date: Fri, 25 Dec 2015 11:00:05 +0000	[thread overview]
Message-ID: <20151225110005.GA2099@dcvr.yhbt.net> (raw)
In-Reply-To: <20151222010216.6684-5-e@80x24.org>

Fixes commit 4c2c2325d2948ec5340e2fcafbee798cf568f5fd
("rename 'GitCatFile' package to 'Git'")
---
 lib/PublicInbox/ExtMsg.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/ExtMsg.pm b/lib/PublicInbox/ExtMsg.pm
index 0b66754..59bbae5 100644
--- a/lib/PublicInbox/ExtMsg.pm
+++ b/lib/PublicInbox/ExtMsg.pm
@@ -75,7 +75,7 @@ sub ext_msg {
 		# TODO: reuse existing PublicInbox::Git objects to save forks
 		my $git = PublicInbox::Git->new($n->{git_dir});
 		my (undef, $type, undef) = $git->check($path);
-		return r302($n->{url}, $mid) if ($type eq 'blob');
+		return r302($n->{url}, $mid) if ($type && $type eq 'blob');
 	}
 
 	# fall back to partial MID matching
-- 
EW


  reply	other threads:[~2015-12-25 11:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-22  1:02 [PATCH 0/4] a bunch of cleanups for future expansion Eric Wong
2015-12-22  1:02 ` [PATCH 1/4] config: hoist out common functions Eric Wong
2015-12-22  1:02 ` [PATCH 2/4] hval: move PRE constant for wrapping UGC here Eric Wong
2015-12-22  1:02 ` [PATCH 3/4] git: cat-file wrapper enhancements Eric Wong
2015-12-22  1:02 ` [PATCH 4/4] rename 'GitCatFile' package to 'Git' Eric Wong
2015-12-25 11:00   ` Eric Wong [this message]
2015-12-26  1:10   ` [PATCH] searchview: fix up Atom feed in search results Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151225110005.GA2099@dcvr.yhbt.net \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).