user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] view: avoid truncating topic at 30 chars
@ 2015-12-04  1:03 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2015-12-04  1:03 UTC (permalink / raw)
  To: meta

It's potentially unsafe (leading to hidden messages) at any level.
---
 lib/PublicInbox/View.pm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index d8fb1cb..f34e1f3 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -822,7 +822,6 @@ sub add_topic {
 		unless ($level == 0) {
 			$topic =~ s/\A\s*\[[^\]]+\]\s*//g;
 		}
-		$topic = substr($topic, 0, 30);
 
 		if (++$state->{subjs}->{$topic} == 1) {
 			push @{$state->{order}}, [ $level, $subj, $topic ];
-- 
EW


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-12-04  1:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-04  1:03 [PATCH] view: avoid truncating topic at 30 chars Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).