From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: meta@public-inbox.org Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 3FA782014B for ; Fri, 25 Sep 2015 02:28:00 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 7/8] git: use fields for GitCatFile Date: Fri, 25 Sep 2015 02:27:56 +0000 Message-Id: <20150925022757.6915-8-e@80x24.org> In-Reply-To: <20150925022757.6915-1-e@80x24.org> References: <20150925022757.6915-1-e@80x24.org> List-Id: Micro-optimization, but it make using Danga::Socket for watching pipe readability easier at some point. --- lib/PublicInbox/GitCatFile.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/PublicInbox/GitCatFile.pm b/lib/PublicInbox/GitCatFile.pm index 3fced28..5403696 100644 --- a/lib/PublicInbox/GitCatFile.pm +++ b/lib/PublicInbox/GitCatFile.pm @@ -8,10 +8,13 @@ use strict; use warnings; use POSIX qw(dup2); require IO::Handle; +use fields qw(git_dir pid in out); sub new { my ($class, $git_dir) = @_; - bless { git_dir => $git_dir }, $class; + my $self = fields::new($class); + $self->{git_dir} = $git_dir; + $self; } sub _cat_file_begin { -- EW