From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/7] nntp: fix XOVER command
Date: Thu, 24 Sep 2015 03:37:15 +0000 [thread overview]
Message-ID: <20150924033721.26231-2-e@80x24.org> (raw)
In-Reply-To: <20150924033721.26231-1-e@80x24.org>
Oops, we need to test commands more closely :x
Add a missing prototype while we're at it for extra
checking.
---
lib/PublicInbox/NNTP.pm | 4 ++--
t/nntpd.t | 9 ++++++++-
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index 6dc0db3..0d0de97 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -762,11 +762,11 @@ sub cmd_xrover ($;$) {
});
}
-sub over_line {
+sub over_line ($$) {
my ($self, $r) = @_;
more($self, join("\t", $r->[0], map {
- my $h = xhdr($r, $_);
+ my $h = hdr_val($r, $_);
defined $h ? $h : '';
} @OVERVIEW ));
}
diff --git a/t/nntpd.t b/t/nntpd.t
index 04444e4..ea2c3df 100644
--- a/t/nntpd.t
+++ b/t/nntpd.t
@@ -144,7 +144,14 @@ EOF
}
}
- # TODO: upgrades and such
+ is_deeply($n->xover('1-'), {
+ '1' => ['hihi',
+ 'Me <me@example.com>',
+ 'Thu, 01 Jan 1970 06:06:06 +0000',
+ '<nntp@example.com>',
+ '',
+ '202',
+ '1' ] }, "XOVER works");
ok(kill('TERM', $pid), 'killed nntpd');
$pid = undef;
--
EW
next prev parent reply other threads:[~2015-09-24 3:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 3:37 [PATCH 0/7] another round of NNTP updates Eric Wong
2015-09-24 3:37 ` Eric Wong [this message]
2015-09-24 3:37 ` [PATCH 2/7] nntpd: additional daemonization options Eric Wong
2015-09-24 3:37 ` [PATCH 3/7] nntpd: hard quit after 30s Eric Wong
2015-09-24 3:37 ` [PATCH 4/7] nntpd: move busy check to NNTP package Eric Wong
2015-09-24 3:37 ` [PATCH 5/7] nntp: avoid infinite loop on partial read Eric Wong
2015-09-24 3:37 ` [PATCH 6/7] nntpd: better encapsulation for shutdown Eric Wong
2015-09-24 3:37 ` [PATCH 7/7] nntpd: support SIGUSR2 in single-process mode, too Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150924033721.26231-2-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).