From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/3] nntp: do not re-enable reads during long responses
Date: Sun, 20 Sep 2015 04:43:19 +0000 [thread overview]
Message-ID: <20150920044320.2338-3-e@80x24.org> (raw)
In-Reply-To: <20150920044320.2338-1-e@80x24.org>
Long responses may leave the buffer momentarily empty,
but we must prevent read events from firing at that point.
---
lib/PublicInbox/NNTP.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index d513953..0e91082 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -754,7 +754,9 @@ sub event_err { $_[0]->close }
sub event_write {
my ($self) = @_;
# only continue watching for readability when we are done writing:
- $self->write(undef) == 1 and $self->watch_read(1);
+ if ($self->write(undef) == 1 && !$self->{long_res}) {
+ $self->watch_read(1);
+ }
}
sub event_read {
--
EW
next prev parent reply other threads:[~2015-09-20 4:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-20 4:43 [PATCH 0/3] more nntpd updates Eric Wong
2015-09-20 4:43 ` [PATCH 1/3] nntpd: support systemd FD inheritance + signals Eric Wong
2015-09-20 4:43 ` Eric Wong [this message]
2015-09-20 4:43 ` [PATCH 3/3] nntp: fix handling of trickled responses Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150920044320.2338-3-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).