From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, T_RP_MATCHES_RCVD shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: meta@public-inbox.org Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id BC8AB1F4B3 for ; Mon, 14 Sep 2015 00:10:08 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] searchview: do not link Atom feed by relevance Date: Mon, 14 Sep 2015 00:10:08 +0000 Message-Id: <20150914001008.21972-1-e@80x24.org> List-Id: Atom feeds only make sense when sorted by time, not when our search indexing rules change and affect relevance. So do not include the relevance option when linking to Atom feeds. However, we shall still honor the 'r' query parameter in case somebody wants to manually include that in the URL for testing/experimental purposes. We simply will not advertise it. --- lib/PublicInbox/SearchView.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm index b65351a..6bc66ce 100644 --- a/lib/PublicInbox/SearchView.pm +++ b/lib/PublicInbox/SearchView.pm @@ -108,7 +108,7 @@ sub search_nav_top { $rv .= qq{summary|}; $rv .= qq{threaded}; } - my $A = $q->qs_html(x => 'A'); + my $A = $q->qs_html(x => 'A', r => undef); $rv .= qq{|Atom}; $rv .= ']'; } @@ -216,7 +216,7 @@ sub html_start { my $query = PublicInbox::Hval->new_oneline($q->{q}); my $qh = $query->as_html; - my $A = $q->qs_html(x => 'A'); + my $A = $q->qs_html(x => 'A', r => undef); my $res = "$qh - search results" . qq{! . -- EW