From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/4] view: do not show References unless a message has them
Date: Sun, 13 Sep 2015 23:35:21 +0000 [thread overview]
Message-ID: <20150913233522.8343-4-e@80x24.org> (raw)
In-Reply-To: <20150913233522.8343-1-e@80x24.org>
It's a waste of space and potentially confusing.
---
lib/PublicInbox/View.pm | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 2cda691..aaab3b2 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -434,7 +434,12 @@ sub headers_to_html_header {
$rv .= "(<a\nhref=\"${upfx}raw\">raw</a>)\n";
my $atom;
if ($srch) {
- $rv .= "<a\nhref=\"${upfx}t/\">References: [expand]</a>\n";
+ if ($header_obj->header('In-Reply-To') ||
+ $header_obj->header('References')) {
+ $rv .= "<a\nhref=\"${upfx}t/\">" .
+ "References: [expand]</a>\n";
+ }
+
$atom = qq{<link\nrel=alternate\ntitle="Atom feed"\n} .
qq!href="${upfx}t.atom"\ntype="application/atom+xml"/>!;
} else {
--
EW
next prev parent reply other threads:[~2015-09-13 23:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 23:35 [PATCH 0/4] minor navigation tweaks Eric Wong
2015-09-13 23:35 ` [PATCH 1/4] view: extra Atom feed link in standalone message view Eric Wong
2015-09-13 23:35 ` [PATCH 2/4] view: use header_obj to avoid extra method calls Eric Wong
2015-09-13 23:35 ` Eric Wong [this message]
2015-09-13 23:35 ` [PATCH 4/4] view: jump to anchor of current message on References Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150913233522.8343-4-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).