From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, T_RP_MATCHES_RCVD shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: meta@public-inbox.org Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id D58B41F6D6 for ; Sun, 13 Sep 2015 23:35:25 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 2/4] view: use header_obj to avoid extra method calls Date: Sun, 13 Sep 2015 23:35:20 +0000 Message-Id: <20150913233522.8343-3-e@80x24.org> In-Reply-To: <20150913233522.8343-1-e@80x24.org> References: <20150913233522.8343-1-e@80x24.org> List-Id: Email::MIME will call the header_obj each time anyways, avoid the extra method lookups and hit header_obj directly for the header lookup. --- lib/PublicInbox/View.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index 6cb340b..2cda691 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -410,7 +410,7 @@ sub headers_to_html_header { my $mid = $header_obj->header('Message-ID'); $mid = PublicInbox::Hval->new_msgid($mid); foreach my $h (qw(From To Cc Subject Date)) { - my $v = $mime->header($h); + my $v = $header_obj->header($h); defined($v) && ($v ne '') or next; $v = PublicInbox::Hval->new_oneline($v); -- EW