user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/3] view: add Atom links in headers for per-message links
Date: Sun, 13 Sep 2015 22:35:47 +0000	[thread overview]
Message-ID: <20150913223547.5083-3-e@80x24.org> (raw)
In-Reply-To: <20150913223547.5083-1-e@80x24.org>

Some user agents will advertise the presence of a feed this
way for users to subscribe to individual topics.
---
 lib/PublicInbox/View.pm | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index de2d667..7e1fb04 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -432,15 +432,19 @@ sub headers_to_html_header {
 	$rv .= 'Message-ID: &lt;' . $mid->as_html . '&gt; ';
 	my $upfx = $full_pfx ? '' : '../';
 	$rv .= "(<a\nhref=\"${upfx}raw\">raw</a>)\n";
+	my $atom;
 	if ($srch) {
 		$rv .= "<a\nhref=\"${upfx}t/\">References: [expand]</a>\n";
+		$atom = qq{<link\nrel=alternate\ntitle="Atom feed"\n} .
+			qq!href="${upfx}t.atom"\ntype="application/atom+xml"/>!;
 	} else {
 		$rv .= _parent_headers_nosrch($header_obj);
+		$atom = '';
 	}
 	$rv .= "\n";
 
 	("<html><head><title>".  join(' - ', @title) .
-	 '</title></head><body>' . PRE_WRAP . $rv);
+	 "</title>$atom</head><body>" . PRE_WRAP . $rv);
 }
 
 sub thread_inline {
@@ -578,12 +582,15 @@ sub anchor_for {
 }
 
 sub thread_html_head {
-	my ($cb, $mime) = @_;
+	my ($cb, $header, $state) = @_;
 	$$cb = $$cb->([200, ['Content-Type'=> 'text/html; charset=UTF-8']]);
 
-	my $s = PublicInbox::Hval->new_oneline($mime->header('Subject'));
+	my $s = PublicInbox::Hval->new_oneline($header->header('Subject'));
 	$s = $s->as_html;
-	$$cb->write("<html><head><title>$s</title></head><body>");
+	$$cb->write("<html><head><title>$s</title>".
+		qq{<link\nrel=alternate\ntitle="Atom feed"\n} .
+		qq!href="../t.atom"\ntype="application/atom+xml"/>! .
+		"</head><body>");
 }
 
 sub pre_anchor_entry {
-- 
EW


  parent reply	other threads:[~2015-09-13 22:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-13 22:35 [PATCH 1/3] feed: consolidate updated tag generation Eric Wong
2015-09-13 22:35 ` [PATCH 2/3] searchview: implement Atom feed for search results Eric Wong
2015-09-13 22:35 ` Eric Wong [this message]
2015-09-13 22:37 ` [PATCH 0/3] expand Atom feeds to " Eric Wong
2015-09-13 23:19   ` [REJECT 4/3] searchview: implement flat view for full message Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150913223547.5083-3-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).