From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/3] view: more consistent prefix for ghost links
Date: Sat, 12 Sep 2015 01:23:30 +0000 [thread overview]
Message-ID: <20150912012332.1542-2-e@80x24.org> (raw)
In-Reply-To: <20150912012332.1542-1-e@80x24.org>
This will be reused for search views.
---
lib/PublicInbox/View.pm | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 9f87546..7d85555 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -598,7 +598,7 @@ sub ghost_parent {
$mid = PublicInbox::Hval->new_msgid($mid);
my $href = $mid->as_href;
my $html = $mid->as_html;
- qq{[parent not found: <<a\nhref="$upfx../$href/">$html</a>>]};
+ qq{[parent not found: <<a\nhref="$upfx$href/">$html</a>>]};
}
sub __thread_entry {
@@ -619,7 +619,7 @@ sub __thread_entry {
foreach my $g (@$ghost) {
$$cb->write("<table\nsummary=ghost><tr><td>" .
(INDENT x $g->[1]) . "</td><td>" .
- PRE_WRAP . ghost_parent('../', $g->[0]) .
+ PRE_WRAP . ghost_parent('../../', $g->[0]) .
'</pre></td></table>');
}
}
@@ -751,7 +751,8 @@ sub inline_dump {
} else {
my $dot = $level == 0 ? '' : '` ';
my $pfx = (INDENT x $level) . $dot;
- $$dst .= $pfx . ghost_parent($upfx, $node->messageid) . "\n";
+ $$dst .= $pfx;
+ $$dst .= ghost_parent("$upfx../", $node->messageid) . "\n";
}
inline_dump($dst, $state, $upfx, $node->child, $level+1);
inline_dump($dst, $state, $upfx, $node->next, $level);
--
EW
next prev parent reply other threads:[~2015-09-12 1:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-12 1:23 [PATCH 0/3] enhance search results Eric Wong
2015-09-12 1:23 ` Eric Wong [this message]
2015-09-12 1:23 ` [PATCH 2/3] searchview: hoist out subroutines for clarity Eric Wong
2015-09-12 1:23 ` [PATCH 3/3] searchview: support displaying entire threads Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150912012332.1542-2-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).