From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <normalperson@yhbt.net>
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: 
X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00,
 T_RP_MATCHES_RCVD shortcircuit=no autolearn=unavailable version=3.3.2
X-Original-To: meta@public-inbox.org
Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net
 (Postfix) with ESMTP id 3E0E063386A for <meta@public-inbox.org>; Mon,  7 Sep
 2015 07:07:36 +0000 (UTC)
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] view: change References link to expand thread
Date: Mon,  7 Sep 2015 07:07:36 +0000
Message-Id: <20150907070736.15899-1-e@80x24.org>
List-Id: <meta@public-inbox.org>

The expanded thread view is generally more useful.  Having links
to more links at the bottom seems to a waste of navigation time.
However, keep the '#r' anchor in case people rely on it for
links.
---
 lib/PublicInbox/View.pm | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 8969e17..5baca97 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -407,7 +407,6 @@ sub headers_to_html_header {
 	my $header_obj = $mime->header_obj;
 	my $mid = $header_obj->header('Message-ID');
 	$mid = PublicInbox::Hval->new_msgid($mid);
-	my $mid_href = $mid->as_href;
 	foreach my $h (qw(From To Cc Subject Date)) {
 		my $v = $mime->header($h);
 		defined($v) && ($v ne '') or next;
@@ -429,10 +428,10 @@ sub headers_to_html_header {
 
 	}
 	$rv .= 'Message-ID: &lt;' . $mid->as_html . '&gt; ';
-	my $raw_ref = $full_pfx ? 'raw' : '../raw';
-	$rv .= "(<a\nhref=\"$raw_ref\">raw</a>)\n";
+	my $upfx = $full_pfx ? '' : '../';
+	$rv .= "(<a\nhref=\"${upfx}raw\">raw</a>)\n";
 	if ($srch) {
-		$rv .= "<a\nhref=\"#r\">References: [see below]</a>\n";
+		$rv .= "<a\nhref=\"${upfx}t/\">References: [expand]</a>\n";
 	} else {
 		$rv .= _parent_headers_nosrch($header_obj);
 	}
-- 
EW