From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] public-inbox-init: use absolute path
Date: Sun, 6 Sep 2015 09:22:58 +0000 [thread overview]
Message-ID: <20150906092258.31431-1-e@80x24.org> (raw)
We actually have no business expanding (e.g. translating ~ to
$HOME) paths from the command-line argument, the shell does
that.
However, we need to make the path absolute instead.
---
public-inbox-init | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/public-inbox-init b/public-inbox-init
index 2d24402..a8f1dd7 100755
--- a/public-inbox-init
+++ b/public-inbox-init
@@ -8,7 +8,7 @@ use PublicInbox::Config;
use File::Temp qw/tempfile/;
use File::Basename qw/dirname/;
use File::Path qw/mkpath/;
-use File::Path::Expand qw/expand_filename/;
+use Cwd qw/abs_path/;
sub x { system(@_) and die join(' ', @_). " failed: $?\n" }
sub usage { print STDERR "Usage: $usage\n"; exit 1 }
@@ -59,7 +59,7 @@ close $fh or die "failed to close $filename: $!\n";
my $pfx = "publicinbox.$name";
my @x = (qw/git config/, "--file=$filename");
-$git_dir = expand_filename($git_dir);
+$git_dir = abs_path($git_dir);
x(qw(git init -q --bare), $git_dir);
foreach my $addr (@address) {
next if $seen{lc($addr)};
--
EW
reply other threads:[~2015-09-06 9:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150906092258.31431-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).