From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, URIBL_BLOCKED shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: meta@public-inbox.org Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 15E75200EE; Sat, 5 Sep 2015 09:18:22 +0000 (UTC) Date: Sat, 5 Sep 2015 09:18:22 +0000 From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] extmsg: add note about the deficiency of the implementation Message-ID: <20150905091821.GA30527@dcvr.yhbt.net> References: <1441443668-21092-1-git-send-email-e@80x24.org> <1441443668-21092-7-git-send-email-e@80x24.org> <20150905091457.GA27857@dcvr.yhbt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150905091457.GA27857@dcvr.yhbt.net> List-Id: ref: http://public-inbox.org/meta/20150905091457.GA27857@dcvr.yhbt.net/ --- lib/PublicInbox/ExtMsg.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/PublicInbox/ExtMsg.pm b/lib/PublicInbox/ExtMsg.pm index 243b6ba..77537c2 100644 --- a/lib/PublicInbox/ExtMsg.pm +++ b/lib/PublicInbox/ExtMsg.pm @@ -95,6 +95,8 @@ sub ext_msg { unshift @pfx, { srch => $ctx->{srch}, url => $url }; foreach my $pfx (@pfx) { my $srch = delete $pfx->{srch} or next; + + # FIXME we may need a proper prefix trie here... if (my $res = $srch->mid_prefix($mid)) { $n_partial += scalar(@$res); $pfx->{res} = $res; -- EW