user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH v2] search: only sort by relevance if requested
Date: Tue, 25 Aug 2015 01:43:39 +0000	[thread overview]
Message-ID: <20150825014339.GA18556@dcvr.yhbt.net> (raw)
In-Reply-To: <1440466520-15163-1-git-send-email-e@80x24.org>

Many of our internal search queries do not care about relevance,
but is used for proper thread displays.
---
 v2: set relevance when doing a regular query

 lib/PublicInbox/Search.pm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/Search.pm b/lib/PublicInbox/Search.pm
index c61d4cf..d780878 100644
--- a/lib/PublicInbox/Search.pm
+++ b/lib/PublicInbox/Search.pm
@@ -76,6 +76,8 @@ sub query {
 	my ($self, $query_string, $opts) = @_;
 	my $query = $self->qp->parse_query($query_string, QP_FLAGS);
 
+	$opts ||= {};
+	$opts->{relevance} = 1;
 	$self->do_enquire($query, $opts);
 }
 
@@ -117,7 +119,11 @@ sub do_enquire {
 
 	$query = Search::Xapian::Query->new(OP_AND, $query, $mail_query);
 	$enquire->set_query($query);
-	$enquire->set_sort_by_relevance_then_value(TS, 0);
+	if ($opts->{relevance}) {
+		$enquire->set_sort_by_relevance_then_value(TS, 0);
+	} else {
+		$enquire->set_sort_by_value(TS, 0);
+	}
 	$opts ||= {};
 	my $offset = $opts->{offset} || 0;
 	my $limit = $opts->{limit} || 50;
-- 
EW


      reply	other threads:[~2015-08-25  1:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-25  1:35 [PATCH] search: only sort by relevance if requested Eric Wong
2015-08-25  1:43 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150825014339.GA18556@dcvr.yhbt.net \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).