From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] thread: workaround for another Mail::Thread bug
Date: Tue, 18 Aug 2015 02:09:06 +0000 [thread overview]
Message-ID: <20150818-CPANRTBug106498-workaround@v1> (raw)
Yay for monkey patching!
ref: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=795913
ref: https://rt.cpan.org/Ticket/Display.html?id=106498
---
lib/PublicInbox/Thread.pm | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/lib/PublicInbox/Thread.pm b/lib/PublicInbox/Thread.pm
index 58efb8d..92404fa 100644
--- a/lib/PublicInbox/Thread.pm
+++ b/lib/PublicInbox/Thread.pm
@@ -1,5 +1,10 @@
# subclass Mail::Thread and use this to workaround a memory leak
# Based on the patch in: https://rt.cpan.org/Public/Bug/Display.html?id=22817
+#
+# Additionally, workaround for a bug where $walk->topmost returns undef:
+# - http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=795913
+# - https://rt.cpan.org/Ticket/Display.html?id=106498
+#
# License differs from the rest of public-inbox (but is compatible):
# This library is free software; you can redistribute it and/or modify
# it under the same terms as Perl itself.
@@ -33,4 +38,19 @@ use base qw(Mail::Thread::Container);
use Scalar::Util qw(weaken);
sub parent { @_ == 2 ? weaken($_[0]->{parent} = $_[1]) : $_[0]->{parent} }
+sub topmost {
+ $_[0]->SUPER::topmost || PublicInbox::Thread::CPANRTBug106498->new;
+}
+
+# ref:
+# - http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=795913
+# - https://rt.cpan.org/Ticket/Display.html?id=106498
+package PublicInbox::Thread::CPANRTBug106498;
+use strict;
+use warnings;
+
+sub new { bless {}, $_[0] }
+
+sub simple_subject {}
+
1;
--
EW
next reply other threads:[~2015-08-18 2:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 2:09 Eric Wong [this message]
2015-08-18 2:15 ` [PATCH] thread: another workaround for a Mail::Thread bug Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150818-CPANRTBug106498-workaround@v1 \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).