user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] view: avoid extraneous space for subject-only messages
Date: Sun, 7 Sep 2014 07:55:11 +0000	[thread overview]
Message-ID: <20140907075510.GA920@dcvr.yhbt.net> (raw)

Sometimes, the subject says it all.
---
 lib/PublicInbox/View.pm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 2e7c874..5076cf9 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -111,10 +111,12 @@ sub index_entry {
 		$s =~ s/\A\s+//s;
 		$s =~ s/\s+\z//s;
 
-		# add prefix:
-		$s =~ s/^/$pfx/sgm;
+		if (length $s) {
+			# add prefix:
+			$s =~ s/^/$pfx/sgm;
 
-		$rv .= $s . "\n";
+			$rv .= $s;
+		}
 		++$part_nr;
 	});
 
-- 
EW

             reply	other threads:[~2014-09-07  7:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-07  7:55 Eric Wong [this message]
2014-09-07  7:57 ` [PATCH] view: fixup dropped newline in the last commit Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140907075510.GA920@dcvr.yhbt.net \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).