user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 4/9] view: add missing newline to inline dump
Date: Fri,  4 Sep 2015 08:58:54 +0000	[thread overview]
Message-ID: <1441357139-23879-5-git-send-email-e@80x24.org> (raw)
In-Reply-To: <1441357139-23879-1-git-send-email-e@80x24.org>

This fixes a regression introduced in
commit 16ca6b7a57266fcb466ffff005bc1d644bad14c1
(view: avoid attempting to find "subject dummy")
---
 lib/PublicInbox/View.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index c53e2e1..6b71703 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -738,8 +738,8 @@ sub inline_dump {
 		}
 		_inline_header($dst, $state, $upfx, $mime, $level);
 	} else {
-		my $pfx = INDENT x $level;
-		$$dst .= $pfx . '` ' . ghost_parent($upfx, $node->messageid);
+		my $pfx = (INDENT x $level) . '` ';
+		$$dst .= $pfx . ghost_parent($upfx, $node->messageid) . "\n";
 	}
 	inline_dump($dst, $state, $upfx, $node->child, $level+1);
 	inline_dump($dst, $state, $upfx, $node->next, $level);
-- 
EW


  parent reply	other threads:[~2015-09-04  8:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-04  8:58 [PATCH 0/9] another round of updates Eric Wong
2015-09-04  8:58 ` [PATCH 1/9] view: eliminate redundant [threaded|flat] link Eric Wong
2015-09-04  8:58 ` [PATCH 2/9] view: one line for thread subjects Eric Wong
2015-09-04  8:58 ` [PATCH 3/9] view: adjust spacing and indentation of index threads Eric Wong
2015-09-04  8:58 ` Eric Wong [this message]
2015-09-04  8:58 ` [PATCH 5/9] view: reduce redundant attributions in permalink refs Eric Wong
2015-09-04  8:58 ` [PATCH 6/9] view: indentation adjustments for collapsed headers Eric Wong
2015-09-04  8:58 ` [PATCH 7/9] view: thread view expands focused message Eric Wong
2015-09-04  8:58 ` [PATCH 8/9] www: extra redirects for the '/'-challenged Eric Wong
2015-09-04  8:58 ` [PATCH 9/9] view: fix broken link to ghost fallback Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441357139-23879-5-git-send-email-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).