From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.1 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, T_RP_MATCHES_RCVD,URIBL_BLOCKED shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: meta@public-inbox.org Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id C4C641FD24 for ; Sun, 30 Aug 2015 10:16:35 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] www: avoid BEGIN block for config loading Date: Sun, 30 Aug 2015 10:16:35 +0000 Message-Id: <1440929795-28953-1-git-send-email-e@80x24.org> List-Id: It fails the syntax check if a user does not have ~/.public-inbox/config setup. Anyways we can safely use ||= on a global since we do not support threads. --- lib/PublicInbox/WWW.pm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm index a01271b..e6eec3d 100644 --- a/lib/PublicInbox/WWW.pm +++ b/lib/PublicInbox/WWW.pm @@ -17,12 +17,10 @@ use constant SSOMA_URL => 'http://ssoma.public-inbox.org/'; use constant PI_URL => 'http://public-inbox.org/'; our $LISTNAME_RE = qr!\A/([\w\.\-]+)!; our $pi_config; -BEGIN { - $pi_config = PublicInbox::Config->new; -} sub run { my ($cgi, $method) = @_; + $pi_config ||= PublicInbox::Config->new; my %ctx = (cgi => $cgi, pi_config => $pi_config); if ($method !~ /\AGET|HEAD\z/) { return r(405, 'Method Not Allowed'); -- EW