From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.3 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, RP_MATCHES_RCVD,URIBL_BLOCKED shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: meta@public-inbox.org Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 718271F81E for ; Mon, 17 Aug 2015 03:38:24 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 3/9] WWW: eliminate "top" parameter for feeds Date: Mon, 17 Aug 2015 03:38:11 +0000 Message-Id: <1439782697-16412-4-git-send-email-e@80x24.org> In-Reply-To: <1439782697-16412-1-git-send-email-e@80x24.org> References: <1439782697-16412-1-git-send-email-e@80x24.org> List-Id: This parameter hasn't been used since commit 5adf8d639e9b5abd4cbac975d70ddc0fb76541fc ("feed: dead code elimination around dropped endpoints") --- lib/PublicInbox/WWW.pm | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm index 5021509..7cbfa35 100644 --- a/lib/PublicInbox/WWW.pm +++ b/lib/PublicInbox/WWW.pm @@ -35,9 +35,9 @@ sub run { } elsif ($path_info =~ m!$LISTNAME_RE\z!o) { invalid_list(\%ctx, $1) || redirect_list_index(\%ctx, $cgi); } elsif ($path_info =~ m!$LISTNAME_RE(?:/|/index\.html)?\z!o) { - invalid_list(\%ctx, $1) || get_index(\%ctx, $cgi, 0); + invalid_list(\%ctx, $1) || get_index(\%ctx, $cgi); } elsif ($path_info =~ m!$LISTNAME_RE/atom\.xml\z!o) { - invalid_list(\%ctx, $1) || get_atom(\%ctx, $cgi, 0); + invalid_list(\%ctx, $1) || get_atom(\%ctx, $cgi); # single-message pages } elsif ($path_info =~ m!$LISTNAME_RE/m/(\S+)\.txt\z!o) { @@ -109,7 +109,7 @@ sub invalid_list_mid { # /$LISTNAME/atom.xml -> Atom feed, includes replies sub get_atom { - my ($ctx, $cgi, $top) = @_; + my ($ctx, $cgi) = @_; require PublicInbox::Feed; [ 200, [ 'Content-Type' => 'application/xml' ], [ PublicInbox::Feed->generate({ @@ -117,14 +117,13 @@ sub get_atom { listname => $ctx->{listname}, pi_config => $pi_config, cgi => $cgi, - top => $top, }) ] ]; } # /$LISTNAME/?r=$GIT_COMMIT -> HTML only sub get_index { - my ($ctx, $cgi, $top) = @_; + my ($ctx, $cgi) = @_; require PublicInbox::Feed; my $srch = searcher($ctx); [ 200, [ 'Content-Type' => 'text/html; charset=UTF-8' ], @@ -135,7 +134,6 @@ sub get_index { pi_config => $pi_config, cgi => $cgi, footer => footer($ctx), - top => $top, }) ] ]; } -- EW