From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH] view: cleaner killing of leading/trailing whitespace
Date: Sun, 16 Aug 2015 09:19:43 +0000 [thread overview]
Message-ID: <1439716783-29015-1-git-send-email-e@80x24.org> (raw)
No point in wasting bytes even if gets compressed over
the wire, it'll use more memory when rendering on the
client.
---
lib/PublicInbox/View.pm | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 660a112..e1632b5 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -142,14 +142,17 @@ sub index_walk {
# Drop signatures
$s =~ s/^-- \n.*\z//ms and $$more = 'more...';
- # kill any leading or trailing whitespace
- $s =~ s/\A\s+//s;
+ # kill any leading or trailing whitespace lines
+ $s =~ s/^[ \t]$//sgm;
$s =~ s/\s+\z//s;
if (length $s) {
# add prefix:
$s =~ s/^/$pfx/sgm;
+ # kill per-line trailing whitespace
+ $s =~ s/[ \t]+$//sgm;
+
$rv .= $s . "\n";
}
$rv;
--
EW
next reply other threads:[~2015-08-16 9:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-16 9:19 Eric Wong [this message]
2015-08-16 20:52 ` [PATCH] view: kill leading empty lines correctly Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439716783-29015-1-git-send-email-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).