From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH] view: trim git patches delimited by /^---$/
Date: Thu, 28 Aug 2014 05:01:00 +0000 [thread overview]
Message-ID: <1409202060-25693-1-git-send-email-e@80x24.org> (raw)
Patches are usually better viewed standalone and are difficult
to judge when nested. So save precious vertical space in our
message index.
---
lib/PublicInbox/View.pm | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 2794339..23cb369 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -81,6 +81,7 @@ sub index_entry {
my ($part) = @_;
return if $part->subparts; # walk_parts already recurses
my $enc = enc_for($part->content_type) || $enc_msg || $enc_utf8;
+ my $more = '';
if ($part_nr > 0) {
my $fn = $part->filename;
@@ -96,13 +97,19 @@ sub index_entry {
# Drop signatures
$s =~ s/\n*-- \n.*\z//s;
+ # drop the remainder of git patches, they're usually better
+ # to review when the full message is viewed
+ if ($s =~ s/\n*---\n.*\z//s) {
+ $more = "$pfx...\n";
+ }
+
# kill any trailing whitespace
$s =~ s/\s+\z//s;
# add prefix:
$s =~ s/^/$pfx/sgm;
- $rv .= $s . "\n";
+ $rv .= $s . "\n$more";
++$part_nr;
});
--
EW
reply other threads:[~2014-08-28 5:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409202060-25693-1-git-send-email-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).