From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-100556-e=80x24.org@sourceware.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS31976 209.132.180.0/23
X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from sourceware.org (server1.sourceware.org [209.132.180.131])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dcvr.yhbt.net (Postfix) with ESMTPS id BA8CF20248
	for <e@80x24.org>; Mon, 11 Mar 2019 19:36:06 +0000 (UTC)
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:from:to:cc:subject:in-reply-to:date:message-id
	:mime-version:content-type; q=dns; s=default; b=qArEHxtSIZwOTRwL
	E8+VhI4nlmF9wVBwTIC7S/6/bBIlgbcb3Q1RctWFcATslvXBFRDzw4vFkVKaYmOD
	c7mkWBEDMyrioVA0YBDbx7nvAq8Wwq7iHrNPVX/UR6HgWVCij5KY9CjFmth7+Gcz
	OfirfKMRkTEmMwkMZFxjFBgIyfw=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:from:to:cc:subject:in-reply-to:date:message-id
	:mime-version:content-type; s=default; bh=sssIJIMZCFyaqKlgQ34mGr
	1Y/+k=; b=J0jquLGWjRYy1xGVlmtbWmzpDqvuYpmDpIVubAZlpkBGiGjXQPpEde
	YEyqfITDpbQKQLDsKf5A8So6K737WHqCVL0LgUBQEXk4dKBb3d/LV8XraJiwQ5Xw
	gU8dZft8/x+LK5nMtPiFMOdf/5J7Uis5B1Pl5FuDk5/2Stc1zX2aA=
Received: (qmail 40290 invoked by alias); 11 Mar 2019 19:36:04 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-e=80x24.org@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 40281 invoked by uid 89); 11 Mar 2019 19:36:04 -0000
Authentication-Results: sourceware.org; auth=none
X-HELO: mx1.redhat.com
From: DJ Delorie <dj@redhat.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] nss_dns: Do not call res_dnok in getnetby* implementation
In-Reply-To: <20190308204424.0744F80DD6B5@oldenburg2.str.redhat.com> (message from Florian Weimer on Fri, 08 Mar 2019 21:44:23 +0100)
Date: Mon, 11 Mar 2019 15:35:58 -0400
Message-ID: <xnwol55hlt.fsf@greed.delorie.com>
MIME-Version: 1.0
Content-Type: text/plain


Florian Weimer <fweimer@redhat.com> writes:
> 2019-03-08  Florian Weimer  <fweimer@redhat.com>
>
> 	* resolv/nss_dns/dns-network.c (getanswer_r): Do not call
> 	res_dnok.

I checked and it does seem that *bp only comes from ns_name_ntop, so as
long as the assumption that ns_name_ntop always produces a valid name is
valid, this patch looks OK to me.