From: DJ Delorie <dj@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org, bergner@linux.ibm.com
Subject: Re: [PATCH] powerpc: Remove power8 strcasestr optimization
Date: Mon, 11 Mar 2024 22:37:15 -0400 [thread overview]
Message-ID: <xnwmq89nvo.fsf@greed.delorie.com> (raw)
In-Reply-To: <20240305201348.2470552-1-adhemerval.zanella@linaro.org>
Adhemerval Zanella <adhemerval.zanella@linaro.org> writes:
> diff --git a/sysdeps/powerpc/powerpc64/multiarch/Makefile b/sysdeps/powerpc/powerpc64/multiarch/Makefile
> - strlen-power8 strcasestr-power8 strcasestr-ppc64 \
> + strlen-power8 \
Removing strcasestr-power8 and strcasestr-ppc64, ok.
> diff --git a/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c b/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c
> index e3e6f5fd10..30fd89e109 100644
> --- a/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c
> +++ b/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c
> @@ -432,14 +432,5 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
> IFUNC_IMPL_ADD (array, i, strcspn, 1,
> __strcspn_ppc))
>
> - /* Support sysdeps/powerpc/powerpc64/multiarch/strcasestr.c. */
> - IFUNC_IMPL (i, name, strcasestr,
> - IFUNC_IMPL_ADD (array, i, strcasestr,
> - hwcap2 & PPC_FEATURE2_ARCH_2_07
> - && hwcap & PPC_FEATURE_HAS_ALTIVEC,
> - __strcasestr_power8)
> - IFUNC_IMPL_ADD (array, i, strcasestr, 1,
> - __strcasestr_ppc))
> -
We're removing all of the three implementations, so ok.
> diff --git a/sysdeps/powerpc/powerpc64/multiarch/strcasestr-power8.S b/sysdeps/powerpc/powerpc64/multiarch/strcasestr-power8.S
> deleted file mode 100644
> diff --git a/sysdeps/powerpc/powerpc64/multiarch/strcasestr-ppc64.c b/sysdeps/powerpc/powerpc64/multiarch/strcasestr-ppc64.c
> deleted file mode 100644
> diff --git a/sysdeps/powerpc/powerpc64/multiarch/strcasestr.c b/sysdeps/powerpc/powerpc64/multiarch/strcasestr.c
> deleted file mode 100644
Ok.
> diff --git a/sysdeps/powerpc/powerpc64/power8/Makefile b/sysdeps/powerpc/powerpc64/power8/Makefile
> deleted file mode 100644
> diff --git a/sysdeps/powerpc/powerpc64/power8/strcasestr-ppc64.c b/sysdeps/powerpc/powerpc64/power8/strcasestr-ppc64.c
> deleted file mode 100644
> diff --git a/sysdeps/powerpc/powerpc64/power8/strcasestr.S b/sysdeps/powerpc/powerpc64/power8/strcasestr.S
> deleted file mode 100644
Ok.
LGTM
Reviewed-by: DJ Delorie <dj@redhat.com>
next prev parent reply other threads:[~2024-03-12 2:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 20:13 [PATCH] powerpc: Remove power8 strcasestr optimization Adhemerval Zanella
2024-03-12 2:37 ` DJ Delorie [this message]
2024-03-15 19:57 ` Peter Bergner
2024-03-18 12:52 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xnwmq89nvo.fsf@greed.delorie.com \
--to=dj@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=bergner@linux.ibm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).