Re: [PATCH 2/4] Add rseq extensible ABI support

[DJ Delorie <dj@redhat.com>]

Michael Jeanson <mjeanson@efficios.com> writes:
> Changes since v8:
> - Fix copyright year in sysdeps/generic/dl-rseq.h
> - Clarify the tcb math comments
> - Add a comment to clarify what enforces the aligment requirements of a
>   pointer calculated from the rseq_offset
> - Remove nonsensical test in tst-rseq-disable
> - Add comments to clarify why the rseq size is 0 when registration fails
>   or is disabled
> - Add comments to explain why whe allocate an rseq area block even when
>   the registration is disabled by tunable
> - Rename 'rseq_size' -> 'rseq_alloc_size' and 'dl_tls_rseq_size' ->
>   'dl_tls_rseq_alloc_size' to clarify the distinction between the
>   allocated rseq size and the size reported to application code in
>   '__rseq_size'

I compared these patches with the previous v8 (hence the abbreviated
review below), noting the above changes, and all seems well.  LGTM.

Reviewed-by: DJ Delorie <dj@redhat.com>

> diff --git a/csu/libc-tls.c b/csu/libc-tls.c

Ok.

> diff --git a/elf/dl-tls.c b/elf/dl-tls.c

Ok.

> diff --git a/elf/rtld_static_init.c b/elf/rtld_static_init.c

Ok.

> diff --git a/nptl/descr.h b/nptl/descr.h

Ok.

> diff --git a/nptl/pthread_create.c b/nptl/pthread_create.c

Ok.

> diff --git a/sysdeps/generic/dl-rseq.h b/sysdeps/generic/dl-rseq.h

Ok.

> diff --git a/sysdeps/generic/ldsodefs.h b/sysdeps/generic/ldsodefs.h

Ok.

> diff --git a/sysdeps/i386/nptl/tcb-access.h b/sysdeps/i386/nptl/tcb-access.h

Ok.

> diff --git a/sysdeps/nptl/dl-tls_init_tp.c b/sysdeps/nptl/dl-tls_init_tp.c

Ok.

> diff --git a/sysdeps/nptl/tcb-access.h b/sysdeps/nptl/tcb-access.h

Ok.

> diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile

Ok.

> diff --git a/sysdeps/unix/sysv/linux/dl-parse_auxv.h b/sysdeps/unix/sysv/linux/dl-parse_auxv.h

Ok.

> diff --git a/sysdeps/unix/sysv/linux/rseq-internal.h b/sysdeps/unix/sysv/linux/rseq-internal.h

Ok.

> diff --git a/sysdeps/unix/sysv/linux/sched_getcpu.c b/sysdeps/unix/sysv/linux/sched_getcpu.c

Ok.

> diff --git a/sysdeps/unix/sysv/linux/tst-rseq-disable-static.c b/sysdeps/unix/sysv/linux/tst-rseq-disable-static.c

Ok.

> diff --git a/sysdeps/unix/sysv/linux/tst-rseq-disable.c b/sysdeps/unix/sysv/linux/tst-rseq-disable.c

Ok.

> diff --git a/sysdeps/unix/sysv/linux/tst-rseq-nptl-static.c b/sysdeps/unix/sysv/linux/tst-rseq-nptl-static.c

Ok.

> diff --git a/sysdeps/unix/sysv/linux/tst-rseq-static.c b/sysdeps/unix/sysv/linux/tst-rseq-static.c

Ok.

> diff --git a/sysdeps/unix/sysv/linux/tst-rseq.c b/sysdeps/unix/sysv/linux/tst-rseq.c

Ok.

> diff --git a/sysdeps/unix/sysv/linux/tst-rseq.h b/sysdeps/unix/sysv/linux/tst-rseq.h

Ok.

> diff --git a/sysdeps/x86_64/nptl/tcb-access.h b/sysdeps/x86_64/nptl/tcb-access.h

Ok.