From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: DJ Delorie Newsgroups: gmane.comp.lib.glibc.alpha Subject: Re: RFC V2 [1/2] test-in-container Date: Tue, 27 Feb 2018 16:17:23 -0500 Message-ID: References: <877eqykulm.fsf@linux-m68k.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1519766128 17701 195.159.176.226 (27 Feb 2018 21:15:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 27 Feb 2018 21:15:28 +0000 (UTC) Cc: libc-alpha@sourceware.org To: Andreas Schwab Original-X-From: libc-alpha-return-90673-glibc-alpha=m.gmane.org@sourceware.org Tue Feb 27 22:15:24 2018 Return-path: Envelope-to: glibc-alpha@blaine.gmane.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:in-reply-to:date:message-id :mime-version:content-type; q=dns; s=default; b=H6dljJCWL2dB2F9i eNIkgonmIH4b+pNgOb08sDZqNp3TwZ6CPyDA1aWjWIuZmbD01DB+Y9hSLvgsfAfY bv913d0hTMDPEZw1sksEBxyqN0BysDu2f26OQxfRdiJn26wfac8urlBch5UUgzcs lAkLN4TEHGkuq0NcO/nocufMJvI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:in-reply-to:date:message-id :mime-version:content-type; s=default; bh=2IWhn+righ0YoffK3OG6vx 3yZ2U=; b=cZ9DUfmW5oYpBO/h6cLXU22cy4Z1UZxiNw0IR/OGmEaDVOgKbISJ/y 7oaxXsY0lHumG5ot+A6QgPPiU+8zW5TTSCTW4zAvRTMY+hZTYNwsRgNCES0bFsBn EdK0rYFsCHmftZHk8nLDaUnLn2a5K/OBZVswH6PthbSxUc2crLB6Q= Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Original-Sender: libc-alpha-owner@sourceware.org Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=decades, Hx-languages-length:387 X-HELO: mx1.redhat.com In-Reply-To: <877eqykulm.fsf@linux-m68k.org> (message from Andreas Schwab on Tue, 27 Feb 2018 22:09:41 +0100) Xref: news.gmane.org gmane.comp.lib.glibc.alpha:83004 Archived-At: Received: from server1.sourceware.org ([209.132.180.131] helo=sourceware.org) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqmap-00046L-By for glibc-alpha@blaine.gmane.org; Tue, 27 Feb 2018 22:15:23 +0100 Received: (qmail 124681 invoked by alias); 27 Feb 2018 21:17:26 -0000 Received: (qmail 124672 invoked by uid 89); 27 Feb 2018 21:17:26 -0000 Andreas Schwab writes: >> + printf ("unable to open %s for reading\n", sname); >> + perror ("the error was"); > > That doesn't work, the printf call can clobber errno. Use error instead. Weird, I've been using that idiom for decades and never had that happen. But, I'll put it on the list of things to change for V3. Thanks!