From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4C1041F462 for ; Tue, 21 May 2019 13:24:42 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:in-reply-to:date:message-id :mime-version:content-type; q=dns; s=default; b=A0Jl3789wQR61/dQ Cx0tOQKolHsM+yUCD66UKaLr+h/r8FGjC5V3abN2zLld42xEgLbWXXlIx1rPKo9c fl3eBd74CYaLXllDILGzeihigSMbmwZXYeqn9OzBGyr4oWtyVsU6YOtuLqYC1DsT HYvQVohTw6HqH2QaYU/S4MV0Bs8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:in-reply-to:date:message-id :mime-version:content-type; s=default; bh=TVnxlxxB4mNYv5VMo22p8f QSmao=; b=k8YF+mWk3Dc3ugTRsrAU1J/ty/fyhpFnlkCNIDLlCSlOPxCwXhOY+E FOfriz3O2rbHTwkNVz7ylhRvJpS1HeV1P1f24l/kVdT/6tk0gCWaP7KZ0YHvAc8A xzCrp1MrSg9qcJz8R01v7cbaRplrm49i8yt8Hce/pyBoHr8cnShiI= Received: (qmail 30926 invoked by alias); 21 May 2019 13:24:39 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 30829 invoked by uid 89); 21 May 2019 13:24:29 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.redhat.com From: DJ Delorie To: Florian Weimer Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] test-in-container: Do not set GCONV_PATH, LOCPATH In-Reply-To: <87lfz09ctu.fsf@oldenburg2.str.redhat.com> (message from Florian Weimer on Tue, 21 May 2019 15:06:21 +0200) Date: Tue, 21 May 2019 09:24:20 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Florian Weimer writes: > Sorry, I don't understand. Why would the user want to run distcc *in > the container*? That was just an example of an environment variable that affects the build. I don't know what environment variables affect the test cases. Timeout-related? Without a review of *every* test that might be run in a container, we won't know what environment variables are valid for the user to specify. > What reason do we have to believe that the host environment variable > settings (regarding terminal, locales and the like) are even valid in > the container? We don't know they're valid, but we don't know they're invalid either. We don't filter the environment for non-container variables. Not over-filtering the container is at least consistent.