From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-100565-e=80x24.org@sourceware.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS31976 209.132.180.0/23
X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from sourceware.org (server1.sourceware.org [209.132.180.131])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dcvr.yhbt.net (Postfix) with ESMTPS id EF56620248
	for <e@80x24.org>; Mon, 11 Mar 2019 21:57:15 +0000 (UTC)
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:from:to:cc:subject:in-reply-to:date:message-id
	:mime-version:content-type; q=dns; s=default; b=vsvN0VAQqjlt2UWS
	QWA8zWSOiOcWL2AvpKRYyHdTuTnVb6fbMOrQ74XVpIqeVLAGWOXl0MvFbujvJiXh
	gcnFABsfNUWB8g2CnN9B2a4KUHWh2NNb6xg49XujU8rifFmoMVH0LbzrMh2tKlEX
	jX5f4BATW4MOw1H/0X2LULRP7x0=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:from:to:cc:subject:in-reply-to:date:message-id
	:mime-version:content-type; s=default; bh=aHoBqgIGwJlZeU42fec7Az
	zdEUY=; b=SB7L5U62jnrRv9JwQJz2DeQ2wTQloqx6WF4w2qSTnT81A1RXi6UrnW
	g91fFmu/4fPiOyEemvbV+QKte+K0x5iPGb8ibM0t9PRd4m/1g3i6z0Lh5uMzIK7n
	THDO8qlu+/zp93YLTAAWGsOYm4gbouSFQct/JXgEMA2KKE/sfSD+c=
Received: (qmail 95876 invoked by alias); 11 Mar 2019 21:57:13 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-e=80x24.org@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 95811 invoked by uid 89); 11 Mar 2019 21:57:12 -0000
Authentication-Results: sourceware.org; auth=none
X-HELO: mx1.redhat.com
From: DJ Delorie <dj@redhat.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] nss_dns: More consistency in corrupt message handling in getnetby*
In-Reply-To: <87ef7dqdtq.fsf@oldenburg2.str.redhat.com> (message from Florian Weimer on Mon, 11 Mar 2019 22:52:01 +0100)
Date: Mon, 11 Mar 2019 17:57:08 -0400
Message-ID: <xnk1h55b2j.fsf@greed.delorie.com>
MIME-Version: 1.0
Content-Type: text/plain

Florian Weimer <fweimer@redhat.com> writes:
> Setting errno to any value is fine as long it's not 0 or ERANGE. 8-)

I was thinking back to a conversation (maybe here) about polluting errno
by setting it *at all* in functions that should only set h_errno.  So, I
flagged a change in whether or not errno was set.  I don't know if that
rule applies in this case, but we should at least know if it does or
not, and say so, so we don't unintentionally make things worse.