From: DJ Delorie via Libc-alpha <libc-alpha@sourceware.org>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [v2] New benchtest: pthread locks
Date: Tue, 13 Oct 2020 21:32:18 -0400 [thread overview]
Message-ID: <xn7drt384d.fsf@greed.delorie.com> (raw)
In-Reply-To: <95b4cd6d-3f74-c26d-aad3-fadd1a0fbf5d@gotplt.org> (message from Siddhesh Poyarekar on Wed, 14 Oct 2020 06:57:13 +0530)
Siddhesh Poyarekar <siddhesh@gotplt.org> writes:
>> +/* The point of this benchmark is to measure the overhead of an empty
>> + critical section or a small critical section. This is never going
>> + to be indicative of real application performance. Instead we are
>> + trying to benchmark the effects of the compiler and the runtime
>> + coupled with a particular set of hardware atomic operations.
>> + The numbers from this benchmark should be taken with a massive gain
>> + of salt and viewed through the eyes of expert reviewers. */
>
> That is a great comment. All benchmarks should have a goal set like
> this so that it is clear to whoever evaluates them that just getting
> better numbers in a specific benchmark is not good enough and one would
> have to evaluate why a certain set of results supports their optimisation.
IIRC Carlos provided that text in one of his internal pre-reviews, so
kudos to him. The remainder of the comments are mine though.
next prev parent reply other threads:[~2020-10-14 1:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 5:34 New benchtest: pthread locks DJ Delorie via Libc-alpha
2020-10-10 3:55 ` [v2] " DJ Delorie via Libc-alpha
2020-10-12 7:05 ` Paul Zimmermann
2020-10-12 17:33 ` DJ Delorie via Libc-alpha
2020-10-13 8:25 ` Paul Zimmermann
2020-10-14 1:27 ` Siddhesh Poyarekar
2020-10-14 1:32 ` DJ Delorie via Libc-alpha [this message]
2020-10-21 15:18 ` DJ Delorie via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xn7drt384d.fsf@greed.delorie.com \
--to=libc-alpha@sourceware.org \
--cc=dj@redhat.com \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).