From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-101962-e=80x24.org@sourceware.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS31976 209.132.180.0/23
X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from sourceware.org (server1.sourceware.org [209.132.180.131])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dcvr.yhbt.net (Postfix) with ESMTPS id 183631F461
	for <e@80x24.org>; Mon, 13 May 2019 20:59:43 +0000 (UTC)
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:from:to:cc:subject:in-reply-to:date:message-id
	:mime-version:content-type; q=dns; s=default; b=Ujsl068VfYkkHOFl
	+xK/bhzruGMpW/OtzkguxXqoaSLZVS4gGs6GkuTUnY7ZXynOSw2WULARbN6UJ/zB
	8p478NHpjNUzUoTloF/UyFCHjV4qONQ+gG3g4Dk9fAs6FDLWYGOFhcFfg+5iRSQu
	gtA8GpwQyi2c8dUWH52jfOQvwUE=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:from:to:cc:subject:in-reply-to:date:message-id
	:mime-version:content-type; s=default; bh=Lajgb43P+GTzwWeESPRhe8
	9vmwA=; b=ffgiB+UJjmROuyj4qfmQH4E+IMqJSKZa3Fadl/eiWrZNKRNIHqXnk4
	yNlidIittCVDZI/5et8rS6I/AXsp9WIzBj6R3AFBTchX64DvoRjqSyFtt6JoF34y
	yRcgCO9ldNYnyc4Wby+/FhkKuiJfOs+hYgi0g7pltXF15j/ejYenM=
Received: (qmail 52488 invoked by alias); 13 May 2019 20:59:40 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-e=80x24.org@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 52270 invoked by uid 89); 13 May 2019 20:59:40 -0000
Authentication-Results: sourceware.org; auth=none
X-HELO: mx1.redhat.com
From: DJ Delorie <dj@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org, codonell@redhat.com
Subject: Re: [PATCH 2/3] support: Export bindir path on support_path
In-Reply-To: <20190513165952.28972-2-adhemerval.zanella@linaro.org> (message from Adhemerval Zanella on Mon, 13 May 2019 13:59:51 -0300)
Date: Mon, 13 May 2019 16:59:36 -0400
Message-ID: <xn4l5ydq9z.fsf@greed.delorie.com>
MIME-Version: 1.0
Content-Type: text/plain

Adhemerval Zanella <adhemerval.zanella@linaro.org> writes:
> 	* support/Makefile (CFLAGS-support_paths.c): Add -DBINDIR_PATH.
> 	* support/support.h (support_bindir_prefix): New variable.
> 	* support/support_paths.c [BINDIR_PATH] (support_bindir_prefix):

LGTM

Reviewed-by: DJ Delorie <dj@redhat.com>

>  		-DINSTDIR_PATH=\"$(prefix)\" \
> -		-DLIBDIR_PATH=\"$(libdir)\"
> +		-DLIBDIR_PATH=\"$(libdir)\" \
> +		-DBINDIR_PATH=\"$(bindir)\"

Ok.

>  /* Corresponds to the install's lib/ or lib64/ directory.  */
>  extern const char support_libdir_prefix[];
> +/* Corresponds to the install's bin/ directory.  */
> +extern const char support_bindir_prefix[];

Ok.

> +
> +#ifdef BINDIR_PATH
> +/* Corresponds to the install's bin/ directory.  */
> +const char support_bindir_prefix[] = BINDIR_PATH;
> +#else
> +# error please -DBINDIR_PATH=something in the Makefile
> +#endif

Ok.