unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] tst-mallinfo2.c: Remove useless trailing semicolon for macro
@ 2021-01-27  2:34 Yang Xu
  2021-01-27  3:39 ` DJ Delorie via Libc-alpha
  0 siblings, 1 reply; 2+ messages in thread
From: Yang Xu @ 2021-01-27  2:34 UTC (permalink / raw
  To: libc-alpha; +Cc: Yang Xu

Macros should not use a trailing semicolon, so remove it.

Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
 malloc/tst-mallinfo2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/malloc/tst-mallinfo2.c b/malloc/tst-mallinfo2.c
index 48e65cb7d7..59a15cf7a8 100644
--- a/malloc/tst-mallinfo2.c
+++ b/malloc/tst-mallinfo2.c
@@ -30,7 +30,7 @@ static void
 print_mi (const char *msg, struct mallinfo2 *m)
 {
   printf("\n%s...\n", msg);
-#define P(f) printf("%s: %zu\n", #f, m->f);
+#define P(f) printf("%s: %zu\n", #f, m->f)
   P(arena);
   P(ordblks);
   P(smblks);
-- 
2.23.0




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] tst-mallinfo2.c: Remove useless trailing semicolon for macro
  2021-01-27  2:34 [PATCH] tst-mallinfo2.c: Remove useless trailing semicolon for macro Yang Xu
@ 2021-01-27  3:39 ` DJ Delorie via Libc-alpha
  0 siblings, 0 replies; 2+ messages in thread
From: DJ Delorie via Libc-alpha @ 2021-01-27  3:39 UTC (permalink / raw
  To: Yang Xu; +Cc: libc-alpha

Yang Xu <xuyang2018.jy@cn.fujitsu.com> writes:
> -#define P(f) printf("%s: %zu\n", #f, m->f);
> +#define P(f) printf("%s: %zu\n", #f, m->f)

LGTM

Reviewed-by: DJ Delorie <dj@redhat.com>

(I'll commit after the branch if nobody else does by then)

(but you can never have enough semicolons ;)


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-27  3:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-27  2:34 [PATCH] tst-mallinfo2.c: Remove useless trailing semicolon for macro Yang Xu
2021-01-27  3:39 ` DJ Delorie via Libc-alpha

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).