From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andreas Schwab Newsgroups: gmane.comp.lib.glibc.alpha Subject: Re: RFC V2 [1/2] test-in-container Date: Wed, 28 Feb 2018 16:04:36 +0100 Message-ID: References: <877eqykulm.fsf@linux-m68k.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1519830164 5771 195.159.176.226 (28 Feb 2018 15:02:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Feb 2018 15:02:44 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) Cc: DJ Delorie , libc-alpha@sourceware.org To: Florian Weimer Original-X-From: libc-alpha-return-90681-glibc-alpha=m.gmane.org@sourceware.org Wed Feb 28 16:02:40 2018 Return-path: Envelope-to: glibc-alpha@blaine.gmane.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=YcTxB lssBTJRO3u/L6YCLq0qzfVGsySutNRwJbGXy7/ylJnlfiLev0XzqBW1mKnCo/UuE OueyG9gpe9/qiUstr51dEA29JjHjRureyhLileWzS+vRKjW+VdWrHGnVqrn5edTB A7gbmuAptdsCrOKUNBqPjAT6QJ+sxGJEQEM170= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=vFOBDo/Yc8M PwqVCRj4LbFcvses=; b=F3a2J5lra8QbSYbPx4S0RRQ9iP8RWva1KV5oByKcpZl 6DvyuosOqynHfKAFTLj9BODTHeYkNL2KlzRRiXw6B6FJe4JHJxshlxhSV4a09NrO qk3AADhu+ZisnTeE5hkBYKfgZR6O/c0XXvXfYLXbbuz3sa46Amr4pxSeWk8RjpUE = Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Original-Sender: libc-alpha-owner@sourceware.org Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=H*r:192.168.8 X-HELO: mail-out.m-online.net X-Auth-Info: 1seT5ndUDNMiMSb1volGN/rMvi3z0K1Xbjw3qLuDZXSZZWL9zsoyLgYSz+MtYYN5 X-Yow: Not SENSUOUS... only ``FROLICSOME''... and in need of DENTAL WORK... in PAIN!!! In-Reply-To: (Florian Weimer's message of "Wed, 28 Feb 2018 13:49:44 +0100") Xref: news.gmane.org gmane.comp.lib.glibc.alpha:83012 Archived-At: Received: from server1.sourceware.org ([209.132.180.131] helo=sourceware.org) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1er3Ff-0001BB-00 for glibc-alpha@blaine.gmane.org; Wed, 28 Feb 2018 16:02:39 +0100 Received: (qmail 3466 invoked by alias); 28 Feb 2018 15:04:42 -0000 Received: (qmail 3455 invoked by uid 89); 28 Feb 2018 15:04:41 -0000 On Feb 28 2018, Florian Weimer wrote: > On 02/27/2018 10:09 PM, Andreas Schwab wrote: >>> +static void >>> +copy_one_file (const char *sname, const char *dname) >>> +{ >>> + int sfd, dfd; >>> + char buf[512]; >>> + size_t rsz; >>> + struct stat st; >>> + struct utimbuf times; >>> + >>> + sfd = open (sname, O_RDONLY); >>> + if (sfd < 0) >>> + { >>> + printf ("unable to open %s for reading\n", sname); >>> + perror ("the error was"); > >> That doesn't work, the printf call can clobber errno. Use error instead. > > Doesn't error print to standard error? perror does, too. > %m is another option. Or strerror. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."