From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id CDB4C1F461 for ; Mon, 20 May 2019 07:42:19 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=BTVQ9 5rJxw6qjKK9kTKW6MAe1NYwyun1RHMZBQRnFyvfVloaz0Mk5fHSif3FWFTSlHF8l fztaZNyVpmdAuS7qvyG6iZfsYDashyp8KiUXzMszG1Mf8BLM4Jj2KToTWr+k4hqP j8aeAQSwONxdzD9eOJRgS28BtNO+XSrVhNV8C8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=OdGmWbjNIZG M2RIcCIllph4+wBA=; b=ZtVQJtzPJ4WAQ+YKRkEw8ZmQhpapk4zaPGDM2kiiZLS GTDHC8cTpxxrGiMjepuifzYkthwjL7f8y1dLmSvzHbgUveNOL7cefJpmUXlvt5Og V/8rm1K/5FhBTEGk9qJ8pH8LKsURUR5JBI48RX0QV+UbumkAdqPmHKmUFVtzXS6I = Received: (qmail 110746 invoked by alias); 20 May 2019 07:42:17 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 110685 invoked by uid 89); 20 May 2019 07:42:16 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.suse.de From: Andreas Schwab To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 2/5] sysvipc: Move __IPC_64 to kernel-features.h References: <20190516151249.19029-1-adhemerval.zanella@linaro.org> <20190516151249.19029-2-adhemerval.zanella@linaro.org> <280924de-4fc5-d917-9bf5-4d159b99d181@linaro.org> X-Yow: Yow! Am I in Milwaukee? Date: Mon, 20 May 2019 09:42:12 +0200 In-Reply-To: <280924de-4fc5-d917-9bf5-4d159b99d181@linaro.org> (Adhemerval Zanella's message of "Thu, 16 May 2019 15:57:50 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain On Mai 16 2019, Adhemerval Zanella wrote: > In file included from ../sysdeps/unix/sysv/linux/arm/kernel-features.h:23, > from ../sysdeps/unix/sysv/linux/lowlevellock-futex.h:25, > from ../sysdeps/nptl/lowlevellock.h:23, > from ../nptl/descr.h:29, > from ../sysdeps/arm/nptl/tls.h:42, > from ../sysdeps/unix/sysv/linux/arm/tls.h:23, > from ../sysdeps/unix/sysv/linux/arm/sysdep.h:33, > from :2: > ../sysdeps/unix/sysv/linux/kernel-features.h:83: error: "__IPC_64" redefined [-Werror] > #define __IPC_64 0x0 > > In file included from ../sysdeps/unix/sysv/linux/sysdep.h:19, > from ../sysdeps/unix/sysv/linux/arm/sysdep.h:27, > from :2: > ../sysdeps/unix/sysv/linux/arm/kernel-features.h:58: note: this is the location of the previous definition > #define __IPC_64 0x100 I think trying to put __IPC_64 in kernel-features.h is the wrong way to solve this. > In general I think unguarded headers file are error-prone. kernel-features.h is special since it is chain-loaded. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."