From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 547C21F44D for ; Thu, 28 Mar 2024 15:29:46 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Omgy/wtN; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=T+tDYgpS; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 59FE63858407 for ; Thu, 28 Mar 2024 15:29:45 +0000 (GMT) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id AC8A43858D20 for ; Thu, 28 Mar 2024 15:29:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AC8A43858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AC8A43858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711639768; cv=none; b=DHWMK4sQ0CIztbEV5BuMG3IguKrqYxGIxvqXsso2H2ifXPrJ+HIAxDm54Pj2VOmmfwRSJt1QVBmRIMH8Lv5+9/hVhbNQF1PQM7NsDSQ1cT+2acFvOcDqaM3Nr86y3Q8mJEwX8wDQuDRTdL6ncgZ05gq7IsuTnDm/3yXT4a7ThPs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711639768; c=relaxed/simple; bh=A1cOFn6ED+Pls2rsI5t908m3RVWnkDqfl+hvZziKpgM=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=eubKInS5hjEXh93vs35AoFW+BQKueZtKwxxix8TD4X9GcaALCfCkLyLaYmZwwJNzopMp+hn2ZFxp5hWNvzHcyEpWH5o0UhQLzJyIfPU11FmvFE5w1mJfqNBm093H1aw3lH0R1CwXer2vyrO2xK2kuCCwqgeixvtHFY7TGTryUec= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from hawking.nue2.suse.org (unknown [10.168.4.11]) by smtp-out2.suse.de (Postfix) with ESMTP id CA34820AF0; Thu, 28 Mar 2024 15:29:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711639765; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9KJholS0s0B1dR0FudCmL4mK7a1J8DsUKscgGu8+cI4=; b=Omgy/wtNuV+axFy9h+EnRZeQkmb03vSXvHBTEDtWsuo4EFyahy5za/5+i33/NfY4LMgbBf ddsSBa0EriNz2IdD7xjt5yNWtH0fYnemZZ0NusNhwgIOyoct9+Vu9ih9wH18ZsB3BRqjm/ 5JinDi6bKhWR/WzCrsnT+TRom38bE4Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711639765; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9KJholS0s0B1dR0FudCmL4mK7a1J8DsUKscgGu8+cI4=; b=T+tDYgpSJ4tWrUDlE8x7GpW0wACi3eg1s9u6e0znx3N5l9ReGxonOJDPpNZ96RLSi5df7l 98CAXZSvhS3tjRDQ== Authentication-Results: smtp-out2.suse.de; none Received: by hawking.nue2.suse.org (Postfix, from userid 17005) id B27E84A04B0; Thu, 28 Mar 2024 16:28:55 +0100 (CET) From: Andreas Schwab To: Joe Simmons-Talbott Cc: libc-alpha@sourceware.org, Florian Weimer , Paul Eggert Subject: Re: [PATCH v12] posix: Deprecate group_member for Linux In-Reply-To: <20240328150911.2391597-1-josimmon@redhat.com> (Joe Simmons-Talbott's message of "Thu, 28 Mar 2024 11:09:07 -0400") References: <20240328150911.2391597-1-josimmon@redhat.com> X-Yow: NANCY!! Why is everything RED?! Date: Thu, 28 Mar 2024 16:28:55 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.65 / 50.00]; BAYES_HAM(-2.45)[97.48%]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; RCVD_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email] X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org On Mär 28 2024, Joe Simmons-Talbott wrote: > diff --git a/sysdeps/posix/euidaccess.c b/sysdeps/posix/euidaccess.c > index 4c5c2220bd..0c19021a30 100644 > --- a/sysdeps/posix/euidaccess.c > +++ b/sysdeps/posix/euidaccess.c > @@ -81,7 +81,7 @@ extern int errno; > > #ifdef _LIBC > > -# define group_member __group_member > +# define group_member __group_member2 > # define euidaccess __euidaccess > > #else > @@ -167,9 +167,14 @@ euidaccess (const char *path, int mode) > || (stats.st_mode & (S_IXUSR | S_IXGRP | S_IXOTH)))) > return 0; > > + int gm = group_member (stats.st_gid); > + if (euid != stats.st_uid && egid != stats.st_gid) > + if (gm == -1) > + return -1; > + I think this should only call group_member if needed, ie if neither euid nor egid match. In the _LIBC case, this could return spurious errors, otherwise. Also, gm should be named something like is_group_member. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."