From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7DACA1F463 for ; Tue, 17 Sep 2019 07:58:41 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=FlQE6 APn9m9sIyiAuYGthIHhYsC6COX3ngfoSzN1HFnpriCFgG0r0oz4aAn/JgV2o9mjf myerG384cby44VvftYhcR2vg3xGxJr1Ut8yy0v9nboGWER2jRJk9aYAjdB7CvaNQ EP6qynKOqJwqC/EuW/mxcQuR1zzTGYoz4MXelU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=tnW6GqY2OzM cMVyLJizL50TbO1Y=; b=rzRj8Zq6gUNzaYSK+hvU+Ky3pIe/IC8kVopqRxC+TZT k8upqCm4PE/yCYkVt794EJoDUczPPFXxoTGtrRqtNOUcw27wm0EQ29sOG84BIIfI zety9OzVISQ7i3BXUss+oCZ5jiZzhbdmFvkYamEZlCTXjLDajJzOv2yhUbsgpyJE = Received: (qmail 130752 invoked by alias); 17 Sep 2019 07:58:38 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 130737 invoked by uid 89); 17 Sep 2019 07:58:38 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.suse.de From: Andreas Schwab To: Alistair Francis Cc: libc-alpha@sourceware.org, joseph@codesourcery.com, macro@wdc.com, alistair23@gmail.com Subject: Re: [PATCH 1/2] sysdeps/stat: Handle 64-bit ino_t types on 32-bit hosts References: <20190916221700.22039-1-alistair.francis@wdc.com> X-Yow: I'm GLAD I remembered to XEROX all my UNDERSHIRTS!! Date: Tue, 17 Sep 2019 09:58:34 +0200 In-Reply-To: <20190916221700.22039-1-alistair.francis@wdc.com> (Alistair Francis's message of "Mon, 16 Sep 2019 15:16:59 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain On Sep 16 2019, Alistair Francis wrote: > @@ -40,7 +40,10 @@ > /* Versions of the `xmknod' interface. */ > #define _MKNOD_VER_LINUX 0 > > -#if defined __USE_FILE_OFFSET64 > +#if defined(__USE_FILE_OFFSET64) || __INO_T_MATCHES_INO64_T == 1 > +# if __INO_T_MATCHES_INO64_T == 1 && __OFF_T_MATCHES_OFF64_T != 1 Why are you using ==/!= 1 instead of !=/== 0? > +# error "ino_t and off_t must both be the same type" > +# endif > # define __field64(type, type64, name) type64 name > #elif __WORDSIZE == 64 > # define __field64(type, type64, name) type name > diff --git a/sysdeps/unix/sysv/linux/generic/wordsize-32/overflow.h b/sysdeps/unix/sysv/linux/generic/wordsize-32/overflow.h > index 45efcd8fd34..3c21da501b2 100644 > --- a/sysdeps/unix/sysv/linux/generic/wordsize-32/overflow.h > +++ b/sysdeps/unix/sysv/linux/generic/wordsize-32/overflow.h > @@ -36,12 +36,16 @@ static inline off_t lseek_overflow (loff_t res) > > static inline int stat_overflow (struct stat *buf) > { > +#if defined (__INO_T_MATCHES_INO64_T) Shouldn't that be #if __INO_T_MATCHES_INO64_T? Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."