unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 9/7] nss_nis: Use NSS_DECLARE_MODULE_FUNCTIONS
Date: Thu, 13 Feb 2020 10:38:49 +0100	[thread overview]
Message-ID: <mvm4kvubzdi.fsf@suse.de> (raw)
In-Reply-To: <871rqyde9f.fsf@oldenburg2.str.redhat.com> (Florian Weimer's message of "Thu, 13 Feb 2020 10:31:56 +0100")

On Feb 13 2020, Florian Weimer wrote:

> * Andreas Schwab:
>
>> On Feb 13 2020, Florian Weimer wrote:
>>
>>> diff --git a/nis/nss_nis/nis-hosts.c b/nis/nss_nis/nis-hosts.c
>>> index 2d08076382..1ee5444cfc 100644
>>> --- a/nis/nss_nis/nis-hosts.c
>>> +++ b/nis/nss_nis/nis-hosts.c
>>> @@ -90,9 +90,16 @@ static bool_t new_start = 1;
>>>  static char *oldkey = NULL;
>>>  static int oldkeylen = 0;
>>>  
>>> +hidden_proto (_nss_nis_endhostent)
>>
>> The hidden_proto should be in the header.
>
> Which header?  nss_nis.h?

netdb.h, after the prototype.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

  reply	other threads:[~2020-02-13  9:38 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12 14:34 [PATCH 0/7] More type safety for NSS modules Florian Weimer
2020-02-12 14:34 ` [PATCH 1/7] nss_compat: Do not use nss_* names for function pointers Florian Weimer
2020-02-12 22:36   ` DJ Delorie
2020-02-12 14:34 ` [PATCH 2/7] nss: Add function types and NSS_DECLARE_MODULE_FUNCTIONS macro to <nss.h> Florian Weimer
2020-02-13  1:10   ` DJ Delorie
2020-02-12 14:34 ` [PATCH 3/7] nss_hesiod: Use NSS_DECLARE_MODULE_FUNCTIONS Florian Weimer
2020-02-13  1:11   ` DJ Delorie
2020-02-12 14:34 ` [PATCH 4/7] nss_compat: " Florian Weimer
2020-02-13  1:14   ` DJ Delorie
2020-02-12 14:34 ` [PATCH 5/7] nss_db: " Florian Weimer
2020-02-13  1:18   ` DJ Delorie
2020-02-12 14:34 ` [PATCH 6/7] nss_files: " Florian Weimer
2020-02-13  1:26   ` DJ Delorie
2020-02-13  8:12     ` Florian Weimer
2020-02-12 14:34 ` [PATCH 7/7] nss_dns: " Florian Weimer
2020-02-13  1:19   ` DJ Delorie
2020-02-12 14:39 ` [PATCH 8/7] nss_nisplus: " Florian Weimer
2020-02-13  1:31   ` DJ Delorie
2020-02-13  8:11     ` Florian Weimer
2020-02-13  9:01 ` [PATCH 9/7] nss_nis: " Florian Weimer
2020-02-13  9:16   ` Andreas Schwab
2020-02-13  9:21   ` Andreas Schwab
2020-02-13  9:31     ` Florian Weimer
2020-02-13  9:38       ` Andreas Schwab [this message]
2020-02-25 14:50         ` Florian Weimer
2020-02-25 15:09           ` Andreas Schwab
2020-02-25 16:10             ` Florian Weimer
2020-02-25 16:41               ` Andreas Schwab
2020-02-25 16:44                 ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mvm4kvubzdi.fsf@suse.de \
    --to=schwab@suse.de \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).