From: Palmer Dabbelt <palmer@sifive.com>
To: schwab@suse.de
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Respect CPPFLAGS when generating stdio-lim.h
Date: Mon, 18 Mar 2019 04:53:02 -0700 (PDT) [thread overview]
Message-ID: <mhng-d8f8e6ff-e211-46b8-a218-f5562f26fa6d@palmer-si-x1c4> (raw)
In-Reply-To: <mvmr2b4pfoc.fsf@suse.de>
On Mon, 18 Mar 2019 04:47:47 PDT (-0700), schwab@suse.de wrote:
> On Mär 18 2019, Palmer Dabbelt <palmer@sifive.com> wrote:
>
>> I'm checking via build-many-glibc.py to make sure this builds, but as
>> that never sets CPPFLAGS I don't think it'll find any potential issues.
>
> Since CPPFLAGS is always set by our makefiles I don't understand this
> comment.
My point is that bulid-many-glibcs.py isn't adding any additional CPPFLAGS, so
we wouldn't notice anything that might crop up because of how users (who
may have set some odd CPPFLAGS) build their glibc.
Maybe that's being too paranoid, though?
next prev parent reply other threads:[~2019-03-18 11:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 9:20 [PATCH] Respect CPPFLAGS when generating stdio-lim.h Palmer Dabbelt
2019-03-18 10:52 ` Andreas Schwab
2019-03-18 11:06 ` Palmer Dabbelt
2019-03-18 11:47 ` Andreas Schwab
2019-03-18 11:53 ` Palmer Dabbelt [this message]
2019-03-18 12:11 ` Andreas Schwab
2019-03-18 12:51 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-d8f8e6ff-e211-46b8-a218-f5562f26fa6d@palmer-si-x1c4 \
--to=palmer@sifive.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).